Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

2017-02-08 Thread Nicholas A. Bellinger
On Tue, 2017-02-07 at 14:44 -0800, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 01:17:46PM +, Nicholas A. Bellinger wrote: > > + if (orig->se_lun_acl != NULL) { > > + pr_warn_ratelimited("Detected existing explicit" > > + "

Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

2017-02-08 Thread Nicholas A. Bellinger
On Tue, 2017-02-07 at 14:44 -0800, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 01:17:46PM +, Nicholas A. Bellinger wrote: > > + if (orig->se_lun_acl != NULL) { > > + pr_warn_ratelimited("Detected existing explicit" > > + "

Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

2017-02-07 Thread Christoph Hellwig
On Tue, Feb 07, 2017 at 01:17:46PM +, Nicholas A. Bellinger wrote: > + if (orig->se_lun_acl != NULL) { > + pr_warn_ratelimited("Detected existing explicit" > + " se_lun_acl->se_lun_group reference for %s" > +

Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

2017-02-07 Thread Christoph Hellwig
On Tue, Feb 07, 2017 at 01:17:46PM +, Nicholas A. Bellinger wrote: > + if (orig->se_lun_acl != NULL) { > + pr_warn_ratelimited("Detected existing explicit" > + " se_lun_acl->se_lun_group reference for %s" > +

[PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

2017-02-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger After the v4.2+ RCU conversion to se_node_acl->lun_entry_hlist, a BUG_ON() was added in core_enable_device_list_for_node() to detect when the passed *lun does not match the existing orig->se_lun pointer reference. However, this scenario can occur

[PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

2017-02-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger After the v4.2+ RCU conversion to se_node_acl->lun_entry_hlist, a BUG_ON() was added in core_enable_device_list_for_node() to detect when the passed *lun does not match the existing orig->se_lun pointer reference. However, this scenario can occur happen when a