Re: [PATCH 1/5] tty: add port flag to suppress ready signalling on open

2020-12-01 Thread Johan Hovold
On Tue, Dec 01, 2020 at 06:49:07AM +0100, Jiri Slaby wrote: > On 30. 11. 20, 16:37, Johan Hovold wrote: > > --- a/include/linux/tty.h > > +++ b/include/linux/tty.h > > @@ -683,6 +684,19 @@ static inline void tty_port_set_kopened(struct > > tty_port *port, bool val) > > clear_bit(TTY_PO

Re: [PATCH 1/5] tty: add port flag to suppress ready signalling on open

2020-11-30 Thread Jiri Slaby
On 01. 12. 20, 8:09, Mychaela Falconia wrote: On 11/30/20, Jiri Slaby wrote: port can be const here. [...] We have assign_bit() for these cases these days. Johan's patch adding test and set accessor inline functions for the new flag follows the style of the existing accessor inline functions

Re: [PATCH 1/5] tty: add port flag to suppress ready signalling on open

2020-11-30 Thread Mychaela Falconia
On 11/30/20, Jiri Slaby wrote: > port can be const here. > [...] > We have assign_bit() for these cases these days. Johan's patch adding test and set accessor inline functions for the new flag follows the style of the existing accessor inline functions for previously existing flags, for the sake

Re: [PATCH 1/5] tty: add port flag to suppress ready signalling on open

2020-11-30 Thread Jiri Slaby
On 30. 11. 20, 16:37, Johan Hovold wrote: --- a/include/linux/tty.h +++ b/include/linux/tty.h @@ -683,6 +684,19 @@ static inline void tty_port_set_kopened(struct tty_port *port, bool val) clear_bit(TTY_PORT_KOPENED, &port->iflags); } +static inline bool tty_port_nordy(struct

Re: [PATCH 1/5] tty: add port flag to suppress ready signalling on open

2020-11-30 Thread Mychaela Falconia
> Add a NORDY port flag to suppress raising the modem-control lines on > open to signal DTE readiness. > > This can be used to implement a NORDY termios control flag to complement > HUPCL, which controls lowering of the modem-control lines on final > close. > > Initially drivers can export the flag

[PATCH 1/5] tty: add port flag to suppress ready signalling on open

2020-11-30 Thread Johan Hovold
Add a NORDY port flag to suppress raising the modem-control lines on open to signal DTE readiness. This can be used to implement a NORDY termios control flag to complement HUPCL, which controls lowering of the modem-control lines on final close. Initially drivers can export the flag through sysfs