Re: [PATCH 1/5] um: port: Move an assignment for the variable "fd" in port_wait()

2017-01-18 Thread Jeff Dike
On Wed, Jan 18, 2017 at 10:56:17PM +0100, SF Markus Elfring wrote: > diff --git a/arch/um/drivers/port_kern.c b/arch/um/drivers/port_kern.c > index 40ca5cc275e9..b2bbda21c5f3 100644 > --- a/arch/um/drivers/port_kern.c > +++ b/arch/um/drivers/port_kern.c > @@ -230,10 +230,10 @@ int port_wait(void *d

[PATCH 1/5] um: port: Move an assignment for the variable "fd" in port_wait()

2017-01-18 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 18 Jan 2017 21:40:29 +0100 A local variable was set to an error code in one case before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. This issue was detected by using the Coc