Re: [PATCH 1/5] usb: phy: twl4030: make runtime pm more reliable.

> > diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c > > index 8e87f54671f3..1a244f34b748 100644 > > --- a/drivers/phy/phy-twl4030-usb.c > > +++ b/drivers/phy/phy-twl4030-usb.c > > @@ -144,6 +144,16 @@ > > #define PMBR1 0x0D > > #define G

Re: [PATCH 1/5] usb: phy: twl4030: make runtime pm more reliable.

Hi, On Monday 23 March 2015 04:05 AM, NeilBrown wrote: > From: NeilBrown > > A construct like: > > if (pm_runtime_suspended(twl->dev)) >pm_runtime_get_sync(twl->dev); > > is against the spirit of the runtime_pm interface as it > makes the internal refcounting useless. >

[PATCH 1/5] usb: phy: twl4030: make runtime pm more reliable.

From: NeilBrown A construct like: if (pm_runtime_suspended(twl->dev)) pm_runtime_get_sync(twl->dev); is against the spirit of the runtime_pm interface as it makes the internal refcounting useless. In this case it is also racy, particularly as 'put_autosuspend' is use to