Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-13 Thread Andy Lutomirski
> On Jan 13, 2018, at 5:52 AM, Van De Ven, Arjan > wrote: > > >>> We were also worried about the indirect calls that are part of the >>> paravirt interfaces when retpolines are not in place. >>> >> >> How could those possibly be any worse than any other indirect call in >> the kernel? > >

RE: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-13 Thread Van De Ven, Arjan
> > We were also worried about the indirect calls that are part of the > > paravirt interfaces when retpolines are not in place. > > > > How could those possibly be any worse than any other indirect call in > the kernel? they're worse if they happen before you write the MSR that then protects th

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-12 Thread Andy Lutomirski
On Thu, Jan 11, 2018 at 9:03 PM, Dave Hansen wrote: > On 01/11/2018 07:01 PM, Raj, Ashok wrote: >> On Thu, Jan 11, 2018 at 06:20:13PM -0800, Andy Lutomirski wrote: >>> On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: > > What's wrong with native_read_msr()? Yes, i think i shou

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-12 Thread Andy Lutomirski
On Thu, Jan 11, 2018 at 7:01 PM, Raj, Ashok wrote: > On Thu, Jan 11, 2018 at 06:20:13PM -0800, Andy Lutomirski wrote: >> On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: >> >> >> >> What's wrong with native_read_msr()? >> > >> > Yes, i think i should have added to msr.h. The names didn't read a

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-12 Thread Woodhouse, David
On Thu, 2018-01-11 at 21:03 -0800, Dave Hansen wrote: > On 01/11/2018 07:01 PM, Raj, Ashok wrote: > > On Thu, Jan 11, 2018 at 06:20:13PM -0800, Andy Lutomirski wrote: > >> On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: > > What's wrong with native_read_msr()? > >>> > >>> Yes, i think

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-12 Thread Josh Poimboeuf
On Thu, Jan 11, 2018 at 09:03:56PM -0800, Dave Hansen wrote: > On 01/11/2018 07:01 PM, Raj, Ashok wrote: > > On Thu, Jan 11, 2018 at 06:20:13PM -0800, Andy Lutomirski wrote: > >> On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: > > What's wrong with native_read_msr()? > >>> > >>> Yes,

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-12 Thread Borislav Petkov
On Thu, Jan 11, 2018 at 05:32:15PM -0800, Ashok Raj wrote: > - Remove including microcode.h, and use native macros from asm/msr.h > - added license header for spec_ctrl.c > > Signed-off-by: Ashok Raj > --- > arch/x86/include/asm/spec_ctrl.h | 17 - > arch/x86/kernel/cpu/spec_ctrl

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-11 Thread Greg KH
On Thu, Jan 11, 2018 at 05:32:15PM -0800, Ashok Raj wrote: > - Remove including microcode.h, and use native macros from asm/msr.h > - added license header for spec_ctrl.c Worst changlog ever :( Why are you touching spec_ctrl.c in this patch? How does it belong here in this series? Come on, you

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-11 Thread Dave Hansen
On 01/11/2018 07:01 PM, Raj, Ashok wrote: > On Thu, Jan 11, 2018 at 06:20:13PM -0800, Andy Lutomirski wrote: >> On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: What's wrong with native_read_msr()? >>> >>> Yes, i think i should have added to msr.h. The names didn't read as a >>> pair,

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-11 Thread Raj, Ashok
On Thu, Jan 11, 2018 at 06:20:13PM -0800, Andy Lutomirski wrote: > On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: > >> > >> What's wrong with native_read_msr()? > > > > Yes, i think i should have added to msr.h. The names didn't read as a > > pair, one was native_read_msr, wrmsrl could be take

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-11 Thread Andy Lutomirski
On Thu, Jan 11, 2018 at 5:52 PM, Raj, Ashok wrote: > On Thu, Jan 11, 2018 at 05:41:34PM -0800, Andy Lutomirski wrote: >> On Thu, Jan 11, 2018 at 5:32 PM, Ashok Raj wrote: >> > - Remove including microcode.h, and use native macros from asm/msr.h >> > - added license header for spec_ctrl.c >> > >>

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-11 Thread Raj, Ashok
On Thu, Jan 11, 2018 at 05:41:34PM -0800, Andy Lutomirski wrote: > On Thu, Jan 11, 2018 at 5:32 PM, Ashok Raj wrote: > > - Remove including microcode.h, and use native macros from asm/msr.h > > - added license header for spec_ctrl.c > > > > Signed-off-by: Ashok Raj [snip] > > +static inline u64

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-11 Thread Andy Lutomirski
On Thu, Jan 11, 2018 at 5:32 PM, Ashok Raj wrote: > - Remove including microcode.h, and use native macros from asm/msr.h > - added license header for spec_ctrl.c > > Signed-off-by: Ashok Raj > --- > arch/x86/include/asm/spec_ctrl.h | 17 - > arch/x86/kernel/cpu/spec_ctrl.c | 1

[PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-11 Thread Ashok Raj
- Remove including microcode.h, and use native macros from asm/msr.h - added license header for spec_ctrl.c Signed-off-by: Ashok Raj --- arch/x86/include/asm/spec_ctrl.h | 17 - arch/x86/kernel/cpu/spec_ctrl.c | 1 + 2 files changed, 17 insertions(+), 1 deletion(-) diff --git