Re: [PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM

2012-08-13 Thread H. Peter Anvin
On 08/13/2012 02:58 PM, Tejun Heo wrote: > > Also, please mention the possibility of using smaller size memory > mappings if e820 didn't align physical memory to GB boundary. > ... as it generally won't. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM

2012-08-13 Thread Tejun Heo
Hello, On Mon, Aug 13, 2012 at 04:47:00PM -0500, Jacob Shin wrote: > Currently direct mappings are created for [ 0 to max_low_pfn< and [ 4GB to max_pfn< backed by actual DRAM. This is fine for holes under 4GB which are covered > by fixed and variable range MTRRs to be UC. However, we run into trou

[PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM

2012-08-13 Thread Jacob Shin
Currently direct mappings are created for [ 0 to max_low_pfn< --- arch/x86/include/asm/page_types.h |9 arch/x86/kernel/setup.c | 108 +++-- 2 files changed, 101 insertions(+), 16 deletions(-) diff --git a/arch/x86/include/asm/page_types.h b/ar

Re: [PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM

2012-08-13 Thread Jacob Shin
On Sat, Aug 11, 2012 at 12:49:48PM -0700, Tejun Heo wrote: > Hello, Jacob. Hi, > > On Thu, Aug 09, 2012 at 04:23:05PM -0500, Jacob Shin wrote: > > +struct range pfn_mapped[E820_X_MAX]; > > +int nr_pfn_mapped; > > Why aren't these __initdata? Are they gonna be used for other > purposes? Yes, t

Re: [PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM

2012-08-13 Thread Jacob Shin
On Sat, Aug 11, 2012 at 11:36:39AM -0700, H. Peter Anvin wrote: > On 08/09/2012 03:03 PM, Yinghai Lu wrote: > > > >can you put those line in another function? > > > >setup_arch is way too big now. > > > > I agree with this ... Jacob, could you rev the patch? Yes of course, I'll send out the revis

Re: [PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM

2012-08-11 Thread Tejun Heo
Hello, Jacob. On Thu, Aug 09, 2012 at 04:23:05PM -0500, Jacob Shin wrote: > +struct range pfn_mapped[E820_X_MAX]; > +int nr_pfn_mapped; Why aren't these __initdata? Are they gonna be used for other purposes? > +void add_pfn_range_mapped(unsigned long start_pfn, unsigned long end_pfn) > +{ > +

Re: [PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM

2012-08-11 Thread H. Peter Anvin
On 08/09/2012 03:03 PM, Yinghai Lu wrote: can you put those line in another function? setup_arch is way too big now. I agree with this ... Jacob, could you rev the patch? -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.

Re: [PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM

2012-08-09 Thread Yinghai Lu
On Thu, Aug 9, 2012 at 2:23 PM, Jacob Shin wrote: > Currently direct mappings are created for [ 0 to max_low_pfn< and [ 4GB to max_pfn< backed by actual DRAM. This is fine for holes under 4GB which are covered > by fixed and variable range MTRRs to be UC. However, we run into trouble > on higher m

[PATCH 1/5] x86: Only direct map addresses that are marked as E820_RAM

2012-08-09 Thread Jacob Shin
Currently direct mappings are created for [ 0 to max_low_pfn< --- arch/x86/include/asm/page_types.h |9 arch/x86/kernel/setup.c | 87 + 2 files changed, 88 insertions(+), 8 deletions(-) diff --git a/arch/x86/include/asm/page_types.h b/arch