Re: [PATCH 1/5] x86: change_page_attr_clear fix

2008-01-31 Thread Andi Kleen
On Thursday 31 January 2008 13:38:45 Thomas Gleixner wrote: > On Thu, 31 Jan 2008, Andi Kleen wrote: > > > On Thursday 31 January 2008 08:35:59 Huang, Ying wrote: > > > This patch replaces __change_page_attr_set_clr() with > > > change_page_attr_set_clr() in change_page_attr_clear() to flush the >

Re: [PATCH 1/5] x86: change_page_attr_clear fix

2008-01-31 Thread Thomas Gleixner
On Thu, 31 Jan 2008, Andi Kleen wrote: > On Thursday 31 January 2008 08:35:59 Huang, Ying wrote: > > This patch replaces __change_page_attr_set_clr() with > > change_page_attr_set_clr() in change_page_attr_clear() to flush the > > TLB/cache properly. > > Good catch :-) It actually only needs to f

Re: [PATCH 1/5] x86: change_page_attr_clear fix

2008-01-31 Thread Ingo Molnar
* Huang, Ying <[EMAIL PROTECTED]> wrote: > This patch replaces __change_page_attr_set_clr() with > change_page_attr_set_clr() in change_page_attr_clear() to flush the > TLB/cache properly. thanks, applied. Thomas just found this bug today too :-) Ingo -- To unsubscribe from this list:

Re: [PATCH 1/5] x86: change_page_attr_clear fix

2008-01-30 Thread Andi Kleen
On Thursday 31 January 2008 08:35:59 Huang, Ying wrote: > This patch replaces __change_page_attr_set_clr() with > change_page_attr_set_clr() in change_page_attr_clear() to flush the > TLB/cache properly. Good catch :-) It actually only needs to flush TLBs not caches in this case. -Andi -- To uns

[PATCH 1/5] x86: change_page_attr_clear fix

2008-01-30 Thread Huang, Ying
This patch replaces __change_page_attr_set_clr() with change_page_attr_set_clr() in change_page_attr_clear() to flush the TLB/cache properly. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/mm/pageattr.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/arch/x86/mm/pag