Re: [PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces

2015-02-11 Thread Chris Rorvick
On Wed, Feb 11, 2015 at 3:33 AM, Takashi Iwai wrote: > At Tue, 10 Feb 2015 23:03:12 -0600, > Chris Rorvick wrote: >> >> Use explicit types to reflect the range of valid values. > > Well, this isn't necessarily to be changed at these places. If we > want to be safer, there should be proper range c

Re: [PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces

2015-02-11 Thread Takashi Iwai
At Tue, 10 Feb 2015 23:03:12 -0600, Chris Rorvick wrote: > > Use explicit types to reflect the range of valid values. Well, this isn't necessarily to be changed at these places. If we want to be safer, there should be proper range checks instead. Also, readers may wonder when they see the differ

[PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces

2015-02-10 Thread Chris Rorvick
Use explicit types to reflect the range of valid values. Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 10 +- sound/usb/line6/driver.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c index 1e5