Re: [PATCH 1/6] ARM: dove: unify clock setup

On 08/11/2012 11:12 AM, Andrew Lunn wrote: + /* Ensure tclk is always clocked */ + clk_prepare_enable(tclk); } "ticking" would be better than clocked. Since this is a root fixed clock, is it necessary to prepare_enable() it? I think prepare and enable become NOPs in this situatio

Re: [PATCH 1/6] ARM: dove: unify clock setup

Hi Sebastian > -static void __init clk_init(void) > +static void __init dove_clk_init(void) > { > tclk = clk_register_fixed_rate(NULL, "tclk", NULL, CLK_IS_ROOT, > -get_tclk()); > +dove_tclk); > > orion_clkdev_i

[PATCH 1/6] ARM: dove: unify clock setup

This patch synchronizes the clock setup of dove with other orion-based platforms. In dove_find_tclk there was a note about DOVE_SAMPLE_HI/LO register to detect tclk. While it might be possible to set a different tclk frequency with reset strapping the Dove datasheets don't tell anything about tcl