RE: [PATCH 1/6] Input: adp5589: use a single variable for error in probe

2020-11-11 Thread Ardelean, Alexandru
> -Original Message- > From: Ardelean, Alexandru > Sent: Thursday, November 12, 2020 8:40 AM > To: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH 1/6] Input: adp5589: use a single variable for error in > probe > > > >

RE: [PATCH 1/6] Input: adp5589: use a single variable for error in probe

2020-11-11 Thread Ardelean, Alexandru
> -Original Message- > From: Dmitry Torokhov > Sent: Thursday, November 12, 2020 2:38 AM > To: Ardelean, Alexandru > Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/6] Input: adp5589: use a single variable for error in > probe > > [External] > >

Re: [PATCH 1/6] Input: adp5589: use a single variable for error in probe

2020-11-11 Thread Dmitry Torokhov
Hi Alexandru, On Wed, Nov 11, 2020 at 10:48:28AM +0200, Alexandru Ardelean wrote: > The 'error' & 'ret' variables are used. This is a bit of duplication. > This change replaces the use of error with the 'ret' variable since the > name is a bit more generic. I really prefer variables that carry

[PATCH 1/6] Input: adp5589: use a single variable for error in probe

2020-11-11 Thread Alexandru Ardelean
The 'error' & 'ret' variables are used. This is a bit of duplication. This change replaces the use of error with the 'ret' variable since the name is a bit more generic. Signed-off-by: Alexandru Ardelean --- drivers/input/keyboard/adp5589-keys.c | 20 +--- 1 file changed, 9