RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

Tuesday, March 15, 2005 2:51 PM Linas Vepstas wrote: >> +void hw_aer_unregister(void) >> +{ >> +struct pci_dev *dev = (struct pci_dev*)host->dev; >> +unsigned short id; >> + >> +id = (dev->bus->number << 8) | dev->devfn; >> + >> +/* Unregister with AER Root driver */ >> +

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

On Tue, Mar 15, 2005 at 04:51:01PM -0600, Linas Vepstas wrote: > Hi, > > On Fri, Mar 11, 2005 at 04:12:18PM -0800, long was heard to remark: > > > +void hw_aer_unregister(void) > > +{ > > + struct pci_dev *dev = (struct pci_dev*)host->dev; I'm more nervous about "host" being defined as a

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

Hi, On Fri, Mar 11, 2005 at 04:12:18PM -0800, long was heard to remark: > +void hw_aer_unregister(void) > +{ > + struct pci_dev *dev = (struct pci_dev*)host->dev; > + unsigned short id; > + > + id = (dev->bus->number << 8) | dev->devfn; > + > + /* Unregister with AER Root

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

Hi, On Fri, Mar 11, 2005 at 04:12:18PM -0800, long was heard to remark: +void hw_aer_unregister(void) +{ + struct pci_dev *dev = (struct pci_dev*)host-dev; + unsigned short id; + + id = (dev-bus-number 8) | dev-devfn; + + /* Unregister with AER Root driver */ +

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

On Tue, Mar 15, 2005 at 04:51:01PM -0600, Linas Vepstas wrote: Hi, On Fri, Mar 11, 2005 at 04:12:18PM -0800, long was heard to remark: +void hw_aer_unregister(void) +{ + struct pci_dev *dev = (struct pci_dev*)host-dev; I'm more nervous about host being defined as a global instead of

RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

Tuesday, March 15, 2005 2:51 PM Linas Vepstas wrote: +void hw_aer_unregister(void) +{ +struct pci_dev *dev = (struct pci_dev*)host-dev; +unsigned short id; + +id = (dev-bus-number 8) | dev-devfn; + +/* Unregister with AER Root driver */ +pcie_aer_unregister(id);

RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

On Saturday, March 12, 2005 1:38 AM Andi Kleen wrote: >I haven't read your code in detail, just a high level remark. > >> +6. Enabling AER Aware Support in PCI Express Device Driver >> + >> +To enable AER aware support requires a software driver to configure >> +the AER capability structure within

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

Nguyen, Tom L wrote: Monday, March 14, 2005 3:01 AM David Vrabel wrote: This patch includes PCIEAER-HOWTO.txt, which describes how the PCI Express Advanced Error Reporting Root driver works. --- linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt Could this be placed in a sub-system subdirectory

RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

Monday, March 14, 2005 3:01 AM David Vrabel wrote: >> This patch includes PCIEAER-HOWTO.txt, which describes how the PCI >> Express Advanced Error Reporting Root driver works. >> >> --- linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt >> >Could this be placed in a sub-system subdirectory

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

long wrote: > This patch includes PCIEAER-HOWTO.txt, which describes how the PCI > Express Advanced Error Reporting Root driver works. > --- linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt Could this be placed in a sub-system subdirectory (creating one if necessary, e.g., pci/)? The root of

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

long wrote: This patch includes PCIEAER-HOWTO.txt, which describes how the PCI Express Advanced Error Reporting Root driver works. --- linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt Could this be placed in a sub-system subdirectory (creating one if necessary, e.g., pci/)? The root of

RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

Monday, March 14, 2005 3:01 AM David Vrabel wrote: This patch includes PCIEAER-HOWTO.txt, which describes how the PCI Express Advanced Error Reporting Root driver works. --- linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt Could this be placed in a sub-system subdirectory (creating one if

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

Nguyen, Tom L wrote: Monday, March 14, 2005 3:01 AM David Vrabel wrote: This patch includes PCIEAER-HOWTO.txt, which describes how the PCI Express Advanced Error Reporting Root driver works. --- linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt Could this be placed in a sub-system subdirectory

RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

On Saturday, March 12, 2005 1:38 AM Andi Kleen wrote: I haven't read your code in detail, just a high level remark. +6. Enabling AER Aware Support in PCI Express Device Driver + +To enable AER aware support requires a software driver to configure +the AER capability structure within its

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

long <[EMAIL PROTECTED]> writes: I haven't read your code in detail, just a high level remark. > +6. Enabling AER Aware Support in PCI Express Device Driver > + > +To enable AER aware support requires a software driver to configure > +the AER capability structure within its device, to initialize

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

long [EMAIL PROTECTED] writes: I haven't read your code in detail, just a high level remark. +6. Enabling AER Aware Support in PCI Express Device Driver + +To enable AER aware support requires a software driver to configure +the AER capability structure within its device, to initialize its

[PATCH 1/6] PCI Express Advanced Error Reporting Driver

This patch includes PCIEAER-HOWTO.txt, which describes how the PCI Express Advanced Error Reporting Root driver works. Signed-off-by: T. Long Nguyen <[EMAIL PROTECTED]> diff -urpN

[PATCH 1/6] PCI Express Advanced Error Reporting Driver

This patch includes PCIEAER-HOWTO.txt, which describes how the PCI Express Advanced Error Reporting Root driver works. Signed-off-by: T. Long Nguyen [EMAIL PROTECTED] diff -urpN linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt