Re: [PATCH 1/6] PM / OPP: reuse of_parse_phandle()

2015-08-10 Thread Viresh Kumar
On 10-08-15, 23:23, Stephen Boyd wrote: > Ok. That's worth a mention in the commit text please. ---8< Message-Id: <8c4503fe1c1c545d5f7ac68351d81d0238532b54.1439275133.git.viresh.ku...@linaro.org> From: Viresh Kumar Date: Thu, 30 Jul 2015 16:58:19 +053

Re: [PATCH 1/6] PM / OPP: reuse of_parse_phandle()

2015-08-10 Thread Stephen Boyd
On 08/11, Viresh Kumar wrote: > On 10-08-15, 23:02, Stephen Boyd wrote: > > > - if (prop->length != sizeof(__be32)) { > > > - dev_err(dev, "%s: Invalid opp desc phandle\n", __func__); > > > - return ERR_PTR(-EINVAL); > > > - } > > > > But we lost this check? Perhaps we can use > >

Re: [PATCH 1/6] PM / OPP: reuse of_parse_phandle()

2015-08-10 Thread Viresh Kumar
On 10-08-15, 23:02, Stephen Boyd wrote: > > - if (prop->length != sizeof(__be32)) { > > - dev_err(dev, "%s: Invalid opp desc phandle\n", __func__); > > - return ERR_PTR(-EINVAL); > > - } > > But we lost this check? Perhaps we can use > of_count_phandle_with_args() to make s

Re: [PATCH 1/6] PM / OPP: reuse of_parse_phandle()

2015-08-10 Thread Stephen Boyd
On 08/10, Viresh Kumar wrote: > We already have a better API to get the opp descriptor block's node from > cpu-node. Lets reuse that instead of creating our own routines for the > same stuff. That cleans the code a lot. > > Signed-off-by: Viresh Kumar Reviewed-by: Stephen Boyd > diff --git a/d

[PATCH 1/6] PM / OPP: reuse of_parse_phandle()

2015-08-09 Thread Viresh Kumar
We already have a better API to get the opp descriptor block's node from cpu-node. Lets reuse that instead of creating our own routines for the same stuff. That cleans the code a lot. Signed-off-by: Viresh Kumar --- drivers/base/power/opp.c | 70 +---