Re: [PATCH 1/6] block: ensure we don't truncate top bits of the request command flags

2016-03-24 Thread Jens Axboe
On 03/24/2016 08:08 PM, Mike Christie wrote: On 03/22/2016 02:01 PM, Jens Axboe wrote: On 03/22/2016 12:59 PM, Christoph Hellwig wrote: On Tue, Mar 22, 2016 at 11:55:15AM -0600, Jens Axboe wrote: Some of the flags that we want to use from the make_request_fn path are now larger than 32-bit, so

Re: [PATCH 1/6] block: ensure we don't truncate top bits of the request command flags

2016-03-24 Thread Mike Christie
On 03/22/2016 02:01 PM, Jens Axboe wrote: > On 03/22/2016 12:59 PM, Christoph Hellwig wrote: >> On Tue, Mar 22, 2016 at 11:55:15AM -0600, Jens Axboe wrote: >>> Some of the flags that we want to use from the make_request_fn path >>> are now larger than 32-bit, so change the functions involved to >>>

Re: [PATCH 1/6] block: ensure we don't truncate top bits of the request command flags

2016-03-22 Thread Jens Axboe
On 03/22/2016 12:59 PM, Christoph Hellwig wrote: On Tue, Mar 22, 2016 at 11:55:15AM -0600, Jens Axboe wrote: Some of the flags that we want to use from the make_request_fn path are now larger than 32-bit, so change the functions involved to accept an u64 instead of an unsigned int. When did we

Re: [PATCH 1/6] block: ensure we don't truncate top bits of the request command flags

2016-03-22 Thread Christoph Hellwig
On Tue, Mar 22, 2016 at 11:55:15AM -0600, Jens Axboe wrote: > Some of the flags that we want to use from the make_request_fn path > are now larger than 32-bit, so change the functions involved to > accept an u64 instead of an unsigned int. When did we start doing that? We really should merge Mike

[PATCH 1/6] block: ensure we don't truncate top bits of the request command flags

2016-03-22 Thread Jens Axboe
Some of the flags that we want to use from the make_request_fn path are now larger than 32-bit, so change the functions involved to accept an u64 instead of an unsigned int. Signed-off-by: Jens Axboe --- block/blk-core.c | 7 --- block/cfq-iosched.c | 2 +- block/elevator.c