Re: [PATCH 1/6] clk: exynos-audss: convert to platform device

2013-09-23 Thread Sylwester Nawrocki
Hi, On 09/23/2013 11:25 PM, Andrew Bresticker wrote: +static int exynos_audss_clk_remove(struct platform_device *pdev) +{ + of_clk_del_provider(pdev->dev.of_node); + + return 0; } Don't we need to unregister all the registered clocks in remove? This also leads to another question: Do

Re: [PATCH 1/6] clk: exynos-audss: convert to platform device

2013-09-21 Thread Tomasz Figa
Hi Andrew, This patch looks good overall, but I have some minor comments inline. On Friday 20 of September 2013 14:13:52 Andrew Bresticker wrote: > The Exynos AudioSS clock controller will later be modified to allow > input clocks to be specified via device-tree in order to support > multiple Exy

[PATCH 1/6] clk: exynos-audss: convert to platform device

2013-09-20 Thread Andrew Bresticker
The Exynos AudioSS clock controller will later be modified to allow input clocks to be specified via device-tree in order to support multiple Exynos SoCs. This will introduce a dependency on the core SoC clock controller being initialized first so that the AudioSS driver can look up its input cloc