Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

2017-07-27 Thread Anup Patel
On Fri, Jul 28, 2017 at 8:43 AM, Vinod Koul wrote: > On Thu, Jul 27, 2017 at 09:42:33AM +0530, Anup Patel wrote: >> On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul wrote: >> > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: > >> >> drivers/dma/bcm-sba-raid.c | 439 >> >> +++

Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

2017-07-27 Thread Vinod Koul
On Thu, Jul 27, 2017 at 09:42:33AM +0530, Anup Patel wrote: > On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: > >> drivers/dma/bcm-sba-raid.c | 439 > >> +++-- > >> 1 file changed, 226 in

Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

2017-07-26 Thread Anup Patel
On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul wrote: > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: >> This patch improves memory allocation in SBA RAID driver in >> following ways: >> 1. Simplify struct sba_request to reduce memory consumption > > what is the simplification?? You ne

Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

2017-07-26 Thread Vinod Koul
On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: > This patch improves memory allocation in SBA RAID driver in > following ways: > 1. Simplify struct sba_request to reduce memory consumption what is the simplification?? You need to document that > 2. Allocate sba resources before regis

[PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

2017-07-25 Thread Anup Patel
This patch improves memory allocation in SBA RAID driver in following ways: 1. Simplify struct sba_request to reduce memory consumption 2. Allocate sba resources before registering dma device Signed-off-by: Anup Patel Reviewed-by: Scott Branden Reviewed-by: Ray Jui Reviewed-by: Vikram Prakash