Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

2007-05-07 Thread Kristian Høgsberg
Christoph Hellwig wrote: On Wed, May 02, 2007 at 02:15:42PM +0200, Stefan Richter wrote: +/* -*- c-basic-offset: 8 -*- Please don't pollute the code with annotation for some editors. OK. + * fw-card.c - card level functions Please don't put the

Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

2007-05-07 Thread Kristian Høgsberg
Pekka Enberg wrote: On 5/2/07, Stefan Richter <[EMAIL PROTECTED]> wrote: I looked around a bit with grep -R and a few search terms but didn't find something definite. Is there any other user of a crc16_itu_t or crc_ccitt or whatever which operates on a (CPU byte ordered) u32[] instead of on a (

Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

2007-05-02 Thread Kristian Høgsberg
Pekka Enberg wrote: On 5/2/07, Stefan Richter <[EMAIL PROTECTED]> wrote: +/* The lib/crc16.c implementation uses the standard (0x8005) + * polynomial, but we need the ITU-T (or CCITT) polynomial (0x1021). + * The implementation below works on an array of host-endian u32 + * words, assuming they'

Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

2007-05-02 Thread Pekka Enberg
On 5/2/07, Stefan Richter <[EMAIL PROTECTED]> wrote: I looked around a bit with grep -R and a few search terms but didn't find something definite. Is there any other user of a crc16_itu_t or crc_ccitt or whatever which operates on a (CPU byte ordered) u32[] instead of on a (network byte ordered)

Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

2007-05-02 Thread Christoph Hellwig
On Wed, May 02, 2007 at 02:15:42PM +0200, Stefan Richter wrote: > +/* -*- c-basic-offset: 8 -*- Please don't pollute the code with annotation for some editors. > + * fw-card.c - card level functions Please don't put the filename into a comment inside the

Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

2007-05-02 Thread Stefan Richter
Pekka Enberg wrote: > On 5/2/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> +/* The lib/crc16.c implementation uses the standard (0x8005) >> + * polynomial, but we need the ITU-T (or CCITT) polynomial (0x1021). >> + * The implementation below works on an array of host-endian u32 >> + * words, ass

Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

2007-05-02 Thread Pekka Enberg
On 5/2/07, Stefan Richter <[EMAIL PROTECTED]> wrote: +/* The lib/crc16.c implementation uses the standard (0x8005) + * polynomial, but we need the ITU-T (or CCITT) polynomial (0x1021). + * The implementation below works on an array of host-endian u32 + * words, assuming they'll be transmited msb