Re: [PATCH 1/6] kconfig: do not call check_conf() for olddefconfig

2018-01-17 Thread Masahiro Yamada
Hi Ulf, 2018-01-13 1:49 GMT+09:00 Ulf Magnusson : > On Fri, Jan 12, 2018 at 1:26 PM, Ulf Magnusson wrote: >> On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada >> wrote: >>> check_conf() traverses the menu tree, but it is completely no-op for >>> olddefconfig because the following if-else block do

Re: [PATCH 1/6] kconfig: do not call check_conf() for olddefconfig

2018-01-12 Thread Ulf Magnusson
On Fri, Jan 12, 2018 at 1:26 PM, Ulf Magnusson wrote: > On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada > wrote: >> check_conf() traverses the menu tree, but it is completely no-op for >> olddefconfig because the following if-else block does nothing. >> >> if (input_mode == listnewconfig) {

Re: [PATCH 1/6] kconfig: do not call check_conf() for olddefconfig

2018-01-12 Thread Ulf Magnusson
On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada wrote: > check_conf() traverses the menu tree, but it is completely no-op for > olddefconfig because the following if-else block does nothing. > > if (input_mode == listnewconfig) { > ... > } else if (input_mode != olddefconfig)

[PATCH 1/6] kconfig: do not call check_conf() for olddefconfig

2018-01-09 Thread Masahiro Yamada
check_conf() traverses the menu tree, but it is completely no-op for olddefconfig because the following if-else block does nothing. if (input_mode == listnewconfig) { ... } else if (input_mode != olddefconfig) { ... } As the help message says, olddefconfig auto