Re: [PATCH 1/6] lguest: host code tidyups

2007-05-16 Thread hch
On Wed, May 16, 2007 at 09:32:16AM +1000, Rusty Russell wrote: > On Tue, 2007-05-15 at 21:47 +1000, Stephen Rothwell wrote: > > On Tue, 15 May 2007 21:42:35 +1000 Stephen Rothwell <[EMAIL PROTECTED]> > > wrote: > > > > > > On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell <[EMAIL PROTECTED]> > > >

Re: [PATCH 1/6] lguest: host code tidyups

2007-05-15 Thread Rusty Russell
On Tue, 2007-05-15 at 21:47 +1000, Stephen Rothwell wrote: > On Tue, 15 May 2007 21:42:35 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > > > On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > - on_each_cpu(adjust_pge, 0, 0, 1); > > > + on_each_c

Re: [PATCH 1/6] lguest: host code tidyups

2007-05-15 Thread Stephen Rothwell
On Tue, 15 May 2007 21:42:35 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > @@ -420,7 +421,7 @@ static int __init init(void) > > lock_cpu_hotplug(); > > if (cpu_has_pge) { /* We have a broader idea of

Re: [PATCH 1/6] lguest: host code tidyups

2007-05-15 Thread Stephen Rothwell
On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > @@ -420,7 +421,7 @@ static int __init init(void) > lock_cpu_hotplug(); > if (cpu_has_pge) { /* We have a broader idea of "global". */ > cpu_had_pge = 1; > - on_each_cpu(adjust_pge,

[PATCH 1/6] lguest: host code tidyups

2007-05-14 Thread Rusty Russell
Christoph Hellwig said runs sparse: 1) page_tables.c unnecessary initialization 2) Change prototype of run_lguest and do cast in caller instead (when we add __user to cast, it runs over another line). Al Viro pointed out the ugly cast in push_lguest_stack(): 3) Stick with unsigned long for arg,