Re: [PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON

On Mon, 28 May 2018, Herbert Xu wrote: On Mon, May 28, 2018 at 06:12:09AM -0700, Davidlohr Bueso wrote: Well, I don't really _want_ them; nor does the ipc code which already does a WARN_ON() (but that goes away in future patches). What I want is to get rid of the return path. So I don't really

Re: [PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON

On Mon, May 28, 2018 at 06:12:09AM -0700, Davidlohr Bueso wrote: > > Well, I don't really _want_ them; nor does the ipc code which already > does a WARN_ON() (but that goes away in future patches). What I want > is to get rid of the return path. So I don't really care if we convert > them to WARN o

Re: [PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON

On Mon, 28 May 2018, Herbert Xu wrote: I don't really see why we need these WARN_ONs. The problem should be quite obvious when you're writing your code. If you really want them perhaps add them to the ipc code instead? Well, I don't really _want_ them; nor does the ipc code which already does

Re: [PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON

On Thu, May 24, 2018 at 02:11:30PM -0700, Davidlohr Bueso wrote: > For the purpose of making rhashtable_init() unable to fail, > we can replace the returning -EINVAL with WARN_ONs whenever > the caller passes bogus parameters during initialization. > > Signed-off-by: Davidlohr Bueso I don't real

[PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON

For the purpose of making rhashtable_init() unable to fail, we can replace the returning -EINVAL with WARN_ONs whenever the caller passes bogus parameters during initialization. Signed-off-by: Davidlohr Bueso --- lib/rhashtable.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) di