Re: [PATCH 1/6] lib/string: Enable string selftesting

2019-02-20 Thread Tobin C. Harding
On Wed, Feb 20, 2019 at 03:57:18PM -0800, Kees Cook wrote: > On Mon, Feb 18, 2019 at 3:24 PM Tobin C. Harding wrote: > > > > Currently we have a test module but it is not tied into the kselftest > > infrastructure. In preparation for adding string manipulation functions > > and testing we should

Re: [PATCH 1/6] lib/string: Enable string selftesting

2019-02-20 Thread Kees Cook
On Tue, Feb 19, 2019 at 1:55 PM Tobin C. Harding wrote: > > On Tue, Feb 19, 2019 at 12:55:09PM +0200, Andy Shevchenko wrote: > > On Tue, Feb 19, 2019 at 4:44 AM Tobin C. Harding wrote: > > > + If unsure, say N. > > Does that mean that this is redundant too? I've started leaving this off Kc

Re: [PATCH 1/6] lib/string: Enable string selftesting

2019-02-20 Thread Kees Cook
On Mon, Feb 18, 2019 at 3:24 PM Tobin C. Harding wrote: > > Currently we have a test module but it is not tied into the kselftest > infrastructure. In preparation for adding string manipulation functions > and testing we should enable kselftest to utilize the test module. > > Enable string testin

Re: [PATCH 1/6] lib/string: Enable string selftesting

2019-02-20 Thread Andy Shevchenko
On Tue, Feb 19, 2019 at 11:55 PM Tobin C. Harding wrote: > On Tue, Feb 19, 2019 at 12:55:09PM +0200, Andy Shevchenko wrote: > > On Tue, Feb 19, 2019 at 4:44 AM Tobin C. Harding wrote: > > > > > > Currently we have a test module but it is not tied into the kselftest > > > infrastructure. In prepa

Re: [PATCH 1/6] lib/string: Enable string selftesting

2019-02-19 Thread Tobin C. Harding
On Tue, Feb 19, 2019 at 12:55:09PM +0200, Andy Shevchenko wrote: > On Tue, Feb 19, 2019 at 4:44 AM Tobin C. Harding wrote: > > > > Currently we have a test module but it is not tied into the kselftest > > infrastructure. In preparation for adding string manipulation functions > > and testing we s

Re: [PATCH 1/6] lib/string: Enable string selftesting

2019-02-19 Thread Andy Shevchenko
On Tue, Feb 19, 2019 at 4:44 AM Tobin C. Harding wrote: > > Currently we have a test module but it is not tied into the kselftest > infrastructure. In preparation for adding string manipulation functions > and testing we should enable kselftest to utilize the test module. > > Enable string testin

[PATCH 1/6] lib/string: Enable string selftesting

2019-02-18 Thread Tobin C. Harding
Currently we have a test module but it is not tied into the kselftest infrastructure. In preparation for adding string manipulation functions and testing we should enable kselftest to utilize the test module. Enable string testing via kselftest infrastructure. Signed-off-by: Tobin C. Harding --