Re: [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

2021-01-06 Thread Michal Hocko
On Wed 06-01-21 17:11:39, Michal Hocko wrote: > On Mon 04-01-21 14:58:38, Muchun Song wrote: > > If the refcount is one when it is migrated, it means that the page > > was freed from under us. So we are done and do not need to migrate. > > Is this common enough that it would warrant the explicit c

Re: [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

2021-01-06 Thread Michal Hocko
On Mon 04-01-21 14:58:38, Muchun Song wrote: > If the refcount is one when it is migrated, it means that the page > was freed from under us. So we are done and do not need to migrate. Is this common enough that it would warrant the explicit check for each migration? > Signed-off-by: Muchun Song

Re: [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

2021-01-05 Thread David Hildenbrand
On 05.01.21 19:04, Yang Shi wrote: > On Tue, Jan 5, 2021 at 8:58 AM David Hildenbrand wrote: >> >> On 04.01.21 07:58, Muchun Song wrote: >>> If the refcount is one when it is migrated, it means that the page >>> was freed from under us. So we are done and do not need to migrate. >>> >>> Signed-off

Re: [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

2021-01-05 Thread Yang Shi
On Sun, Jan 3, 2021 at 11:01 PM Muchun Song wrote: > > If the refcount is one when it is migrated, it means that the page > was freed from under us. So we are done and do not need to migrate. > > Signed-off-by: Muchun Song > --- > mm/migrate.c | 6 ++ > 1 file changed, 6 insertions(+) > > di

Re: [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

2021-01-05 Thread Yang Shi
On Tue, Jan 5, 2021 at 8:58 AM David Hildenbrand wrote: > > On 04.01.21 07:58, Muchun Song wrote: > > If the refcount is one when it is migrated, it means that the page > > was freed from under us. So we are done and do not need to migrate. > > > > Signed-off-by: Muchun Song > > --- > > mm/migra

Re: [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

2021-01-05 Thread David Hildenbrand
On 04.01.21 07:58, Muchun Song wrote: > If the refcount is one when it is migrated, it means that the page > was freed from under us. So we are done and do not need to migrate. > > Signed-off-by: Muchun Song > --- > mm/migrate.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/

Re: [PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

2021-01-04 Thread Mike Kravetz
On 1/3/21 10:58 PM, Muchun Song wrote: > If the refcount is one when it is migrated, it means that the page > was freed from under us. So we are done and do not need to migrate. > > Signed-off-by: Muchun Song > --- > mm/migrate.c | 6 ++ > 1 file changed, 6 insertions(+) Thanks! Reviewed-b

[PATCH 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

2021-01-03 Thread Muchun Song
If the refcount is one when it is migrated, it means that the page was freed from under us. So we are done and do not need to migrate. Signed-off-by: Muchun Song --- mm/migrate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/mm/migrate.c b/mm/migrate.c index 4385f2fb5d18..a6631c4eb6a