Re: [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label

2017-11-21 5:31 GMT+09:00 Wolfram Sang : > >> - ret = PTR_ERR(priv->clk); >> - dev_err(>dev, "cannot get clock: %d\n", ret); >> - goto eprobe; >> + dev_err(>dev, "cannot get clock\n"); >> + return PTR_ERR(priv->clk); >

Re: [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label

2017-11-21 5:31 GMT+09:00 Wolfram Sang : > >> - ret = PTR_ERR(priv->clk); >> - dev_err(>dev, "cannot get clock: %d\n", ret); >> - goto eprobe; >> + dev_err(>dev, "cannot get clock\n"); >> + return PTR_ERR(priv->clk); > > Why dropping the

Re: [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label

> - ret = PTR_ERR(priv->clk); > - dev_err(>dev, "cannot get clock: %d\n", ret); > - goto eprobe; > + dev_err(>dev, "cannot get clock\n"); > + return PTR_ERR(priv->clk); Why dropping the 'ret' printout? Will it be printed by the core?

Re: [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label

> - ret = PTR_ERR(priv->clk); > - dev_err(>dev, "cannot get clock: %d\n", ret); > - goto eprobe; > + dev_err(>dev, "cannot get clock\n"); > + return PTR_ERR(priv->clk); Why dropping the 'ret' printout? Will it be printed by the core?

[PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label

"goto eprobe" does nothing useful. Return directly. Signed-off-by: Masahiro Yamada --- drivers/mmc/host/renesas_sdhi_core.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/renesas_sdhi_core.c

[PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label

"goto eprobe" does nothing useful. Return directly. Signed-off-by: Masahiro Yamada --- drivers/mmc/host/renesas_sdhi_core.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index