Re: [PATCH 1/6] msi: Kill msi_lookup_irq

2007-01-28 Thread Eric W. Biederman
Paul Mackerras <[EMAIL PROTECTED]> writes: > Eric W. Biederman writes: > >> @@ -693,15 +664,14 @@ int pci_enable_msi(struct pci_dev* dev) >> if (!pos) >> return -EINVAL; >> >> -WARN_ON(!msi_lookup_irq(dev, PCI_CAP_ID_MSI)); >> +WARN_ON(!!dev->msi_enabled); > > Minor nit

Re: [PATCH 1/6] msi: Kill msi_lookup_irq

2007-01-28 Thread Paul Mackerras
Eric W. Biederman writes: > @@ -693,15 +664,14 @@ int pci_enable_msi(struct pci_dev* dev) > if (!pos) > return -EINVAL; > > - WARN_ON(!msi_lookup_irq(dev, PCI_CAP_ID_MSI)); > + WARN_ON(!!dev->msi_enabled); Minor nit: what's wrong with just WARN_ON(dev->msi_enabled) ?

[PATCH 1/6] msi: Kill msi_lookup_irq

2007-01-28 Thread Eric W. Biederman
The function msi_lookup_irq was horrible. As a side effect of running it changed dev->irq, and then the callers would need to change it back. In addition it does a global scan through all of the irqs, which seems to be the sole justification of the msi_lock. To remove the neede for msi_lookup_i