Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-12-05 Thread Richard Cochran
On Mon, Dec 05, 2016 at 12:25:57PM -0600, Grygorii Strashko wrote: > >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> @@ -113,6 +113,15 @@ Optional properties: > >>will only initial

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-12-05 Thread Grygorii Strashko
On 12/05/2016 08:49 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> From: WingMan Kwok >> >> This patch adds support of the cpts device found in the >> gbe and 10gbe ethernet switches on the keystone 2 SoCs >> (66AK2E/L/Hx, 66AK2Gx). >> >> Signed-of

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-12-05 Thread Rob Herring
On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: > From: WingMan Kwok > > This patch adds support of the cpts device found in the > gbe and 10gbe ethernet switches on the keystone 2 SoCs > (66AK2E/L/Hx, 66AK2Gx). > > Signed-off-by: WingMan Kwok > Signed-off-by: Grygorii Strash

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-11-30 Thread Richard Cochran
On Wed, Nov 30, 2016 at 11:31:56AM -0600, Grygorii Strashko wrote: > ok. Seems my assumption that ndo_open/ndo_close serialized by > rtnl_lock is incorrect. Right? No, you were right in the first place. The open/close are indeed serialized by the rtnl lock. Sorry for the noise, Richard

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-11-30 Thread Grygorii Strashko
On 11/30/2016 03:44 AM, Richard Cochran wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> @@ -678,6 +744,9 @@ struct gbe_priv { >> int num_et_stats; >> /* Lock for updating the hwstats */ >> spinlock_t h

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-11-30 Thread Richard Cochran
On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: > @@ -678,6 +744,9 @@ struct gbe_priv { > int num_et_stats; > /* Lock for updating the hwstats */ > spinlock_t hw_stats_lock; > + > + int

[PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-11-28 Thread Grygorii Strashko
From: WingMan Kwok This patch adds support of the cpts device found in the gbe and 10gbe ethernet switches on the keystone 2 SoCs (66AK2E/L/Hx, 66AK2Gx). Signed-off-by: WingMan Kwok Signed-off-by: Grygorii Strashko --- .../devicetree/bindings/net/keystone-netcp.txt | 9 + drivers/net/et