Re: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing

2015-01-28 Thread Stephen Boyd
On 01/28, Andy Gross wrote: > On Wed, Jan 28, 2015 at 06:11:50PM -0800, Stephen Boyd wrote: > > > > > > +- syscon-tcsr: indicates phandle of TCSR syscon node > > > > Make this optional but required if any child nodes use dma? > > To enforce that I'd have to determine that a child has a dmas. I

Re: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing

2015-01-28 Thread Andy Gross
On Wed, Jan 28, 2015 at 06:11:50PM -0800, Stephen Boyd wrote: > > Required properties: > > -- compatible: must contain "qcom,gsbi-v1.0.0" for APQ8064/IPQ8064 > > +- compatible: Should contain: > > + "qcom,gsbi-ipq8064" for IPQ8064 > > + "qcom,gsbi-apq8064" for APQ8064 >

Re: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing

2015-01-28 Thread Andy Gross
On Tue, Jan 27, 2015 at 07:11:50PM -0800, Bjorn Andersson wrote: > On Tue 27 Jan 14:10 PST 2015, Andy Gross wrote: > > This solution looks good, just some style things. > > > diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c > [..] > > +#define MAX_GSBI 12 > > + >

Re: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing

2015-01-28 Thread Stephen Boyd
On 01/27, Andy Gross wrote: > This patch adds automatic configuration for the ADM CRCI muxing required to > support DMA operations for GSBI clients. The GSBI mode and instance determine > the correct TCSR ADM CRCI MUX value that must be programmed so that the DMA > works properly. > > Signed-off-

Re: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing

2015-01-28 Thread Andy Gross
On Wed, Jan 28, 2015 at 11:05:50AM +0200, Stanimir Varbanov wrote: > > > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > > index 7bd2c94..32f20be 100644 > > --- a/drivers/soc/qcom/Kconfig > > +++ b/drivers/soc/qcom/Kconfig > > @@ -4,6 +4,7 @@ > > config QCOM_GSBI > >

Re: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing

2015-01-28 Thread Stanimir Varbanov
Hi Andy, On 01/28/2015 12:10 AM, Andy Gross wrote: > This patch adds automatic configuration for the ADM CRCI muxing required to > support DMA operations for GSBI clients. The GSBI mode and instance determine > the correct TCSR ADM CRCI MUX value that must be programmed so that the DMA > works pr

Re: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing

2015-01-27 Thread Bjorn Andersson
On Tue 27 Jan 14:10 PST 2015, Andy Gross wrote: This solution looks good, just some style things. > diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c [..] > +#define MAX_GSBI 12 > + > +#define TCSR_ADM_CRCI_BASE 0x70 > + > +struct crci_config { > + u32 num

[PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing

2015-01-27 Thread Andy Gross
This patch adds automatic configuration for the ADM CRCI muxing required to support DMA operations for GSBI clients. The GSBI mode and instance determine the correct TCSR ADM CRCI MUX value that must be programmed so that the DMA works properly. Signed-off-by: Andy Gross --- .../devicetree/bind