Re: [PATCH 1/6] soundwire: qcom: add support to missing transport params

2021-02-01 Thread Pierre-Louis Bossart
  struct qcom_swrm_port_config {   u8 si;   u8 off1;   u8 off2;   u8 bp_mode; +    u8 hstart; +    u8 hstop; +    u8 word_length; +    u8 bgp_count; I couldn't figure out what 'bgp' was and had to search. Not sure how you came up with this abbreviation of "qcom,ports-block-gr

Re: [PATCH 1/6] soundwire: qcom: add support to missing transport params

2021-02-01 Thread Srinivas Kandagatla
On 29/01/2021 19:20, Pierre-Louis Bossart wrote:   struct qcom_swrm_port_config {   u8 si;   u8 off1;   u8 off2;   u8 bp_mode; +    u8 hstart; +    u8 hstop; +    u8 word_length; +    u8 bgp_count; I couldn't figure out what 'bgp' was and had to search. Not sure how you ca

Re: [PATCH 1/6] soundwire: qcom: add support to missing transport params

2021-02-01 Thread Srinivas Kandagatla
On 01/02/2021 14:13, Vinod Koul wrote: + + ret = of_property_read_u8_array(np, "qcom,ports-hstop", hstop, nports); + if (ret) + memset(hstop, SWR_INVALID_PARAM, QCOM_SDW_MAX_PORTS); why not memset the whole area here and then populate it..? That is other way to do

Re: [PATCH 1/6] soundwire: qcom: add support to missing transport params

2021-02-01 Thread Vinod Koul
On 29-01-21, 17:32, Srinivas Kandagatla wrote: > Some of the transport parameters derived from device tree > are not fully parsed by the driver. > > This patch adds support to parse those missing parameters. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/soundwire/qcom.c | 107 +

Re: [PATCH 1/6] soundwire: qcom: add support to missing transport params

2021-01-29 Thread Pierre-Louis Bossart
struct qcom_swrm_port_config { u8 si; u8 off1; u8 off2; u8 bp_mode; + u8 hstart; + u8 hstop; + u8 word_length; + u8 bgp_count; I couldn't figure out what 'bgp' was and had to search. Not sure how you came up with this abbreviation of

[PATCH 1/6] soundwire: qcom: add support to missing transport params

2021-01-29 Thread Srinivas Kandagatla
Some of the transport parameters derived from device tree are not fully parsed by the driver. This patch adds support to parse those missing parameters. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 107 +-- 1 file changed, 103 insertions(