Re: [PATCH 1/7] Compiler Attributes: remove unused attributes

2018-09-03 Thread Miguel Ojeda
On Sun, Sep 2, 2018 at 9:54 PM, Arnd Bergmann wrote: > On Fri, Aug 31, 2018 at 11:27 PM Nick Desaulniers > wrote: >> On Fri, Aug 31, 2018 at 1:23 PM Miguel Ojeda >> >> > I guess that >> > is breaking ARM clang builds at the moment (didn't check)? >> >> Huh? > > 32-bit ARM has a number of problems

Re: [PATCH 1/7] Compiler Attributes: remove unused attributes

2018-09-02 Thread Arnd Bergmann
On Fri, Aug 31, 2018 at 11:27 PM Nick Desaulniers wrote: > On Fri, Aug 31, 2018 at 1:23 PM Miguel Ojeda > wrote: > > On Fri, Aug 31, 2018 at 8:43 PM, Nick Desaulniers > > > I don't think minimal supported versions are required for these clean > > > ups, and would not block these patches from land

Re: [PATCH 1/7] Compiler Attributes: remove unused attributes

2018-08-31 Thread Nick Desaulniers
On Fri, Aug 31, 2018 at 1:23 PM Miguel Ojeda wrote: > > On Fri, Aug 31, 2018 at 8:43 PM, Nick Desaulniers > wrote: > > On Fri, Aug 31, 2018 at 10:28 AM Joe Perches wrote: > >> > >> On Fri, 2018-08-31 at 19:05 +0200, Miguel Ojeda wrote: > >> > __optimize and __deprecate_for_modules are unused in

Re: [PATCH 1/7] Compiler Attributes: remove unused attributes

2018-08-31 Thread Miguel Ojeda
On Fri, Aug 31, 2018 at 8:43 PM, Nick Desaulniers wrote: > On Fri, Aug 31, 2018 at 10:28 AM Joe Perches wrote: >> >> On Fri, 2018-08-31 at 19:05 +0200, Miguel Ojeda wrote: >> > __optimize and __deprecate_for_modules are unused in >> > the whole kernel tree. Simply drop them. >> >> Nice series, th

Re: [PATCH 1/7] Compiler Attributes: remove unused attributes

2018-08-31 Thread Joe Perches
On Fri, 2018-08-31 at 11:43 -0700, Nick Desaulniers wrote: > I don't think minimal supported versions are required for these clean > ups, and would not block these patches from landing on that. Nor would I, but it's one of those symmetry things. Likely, someone would eventually complain if their

Re: [PATCH 1/7] Compiler Attributes: remove unused attributes

2018-08-31 Thread Nick Desaulniers
On Fri, Aug 31, 2018 at 10:28 AM Joe Perches wrote: > > On Fri, 2018-08-31 at 19:05 +0200, Miguel Ojeda wrote: > > __optimize and __deprecate_for_modules are unused in > > the whole kernel tree. Simply drop them. > > Nice series, thanks Miguel. > > It'd be good to have a cover letter for the serie

Re: [PATCH 1/7] Compiler Attributes: remove unused attributes

2018-08-31 Thread Nick Desaulniers
On Fri, Aug 31, 2018 at 10:05 AM Miguel Ojeda wrote: > > __optimize and __deprecate_for_modules are unused in > the whole kernel tree. Simply drop them. Indeed. Reviewed-by: Nick Desaulniers > > Cc: Eli Friedman > Cc: Christopher Li > Cc: Kees Cook > Cc: Ingo Molnar > Cc: Geert Uytterhoeven

Re: [PATCH 1/7] Compiler Attributes: remove unused attributes

2018-08-31 Thread Joe Perches
On Fri, 2018-08-31 at 19:05 +0200, Miguel Ojeda wrote: > __optimize and __deprecate_for_modules are unused in > the whole kernel tree. Simply drop them. Nice series, thanks Miguel. It'd be good to have a cover letter for the series. And I believe there should be the equivalent of: #if GCC_VERSI

[PATCH 1/7] Compiler Attributes: remove unused attributes

2018-08-31 Thread Miguel Ojeda
__optimize and __deprecate_for_modules are unused in the whole kernel tree. Simply drop them. Cc: Eli Friedman Cc: Christopher Li Cc: Kees Cook Cc: Ingo Molnar Cc: Geert Uytterhoeven Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Masahiro Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: N