Re: [PATCH 1/7] cxgb3 - Fix SGE page management

2007-05-30 Thread Divy Le Ray
Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Streamline page management on RX. Fix dma mappings. NAK #2: You should use the page_address(page) accessor rather than creating a struct member in the same struct as your page, solely to contain the virtual

Re: [PATCH 1/7] cxgb3 - Fix SGE page management

2007-05-30 Thread Divy Le Ray
Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Divy Le Ray [EMAIL PROTECTED] Streamline page management on RX. Fix dma mappings. NAK #2: You should use the page_address(page) accessor rather than creating a struct member in the same struct as your page, solely to contain the virtual

Re: [PATCH 1/7] cxgb3 - Fix SGE page management

2007-05-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Streamline page management on RX. Fix dma mappings. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> NAK #1: "streamline" is not a bug-fixes-only change, which is the only type of change appropriate for 2.6.22-rc. NAK #2: You

Re: [PATCH 1/7] cxgb3 - Fix SGE page management

2007-05-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray [EMAIL PROTECTED] Streamline page management on RX. Fix dma mappings. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] NAK #1: streamline is not a bug-fixes-only change, which is the only type of change appropriate for 2.6.22-rc. NAK #2: You should

[PATCH 1/7] cxgb3 - Fix SGE page management

2007-05-26 Thread divy
From: Divy Le Ray <[EMAIL PROTECTED]> Streamline page management on RX. Fix dma mappings. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h | 38 ++-- drivers/net/cxgb3/sge.c | 425 ++- 2 files changed, 233

[PATCH 1/7] cxgb3 - Fix SGE page management

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Streamline page management on RX. Fix dma mappings. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/adapter.h | 38 ++-- drivers/net/cxgb3/sge.c | 425 ++- 2 files changed, 233 insertions(+),