Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-15 Thread Cornelia Huck
On Tue, 15 Jan 2008 17:13:22 +0800, Dave Young <[EMAIL PROTECTED]> wrote: > > Add the following class iteration functions for driver use: > class_for_each_device > class_find_device > class_for_each_child > class_find_child > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> Acked-by: Cornelia

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-15 Thread Dave Young
Add the following class iteration functions for driver use: class_for_each_device class_find_device class_for_each_child class_find_child Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- drivers/base/class.c | 159 + include/linux/device.h |

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-15 Thread Dave Young
Add the following class iteration functions for driver use: class_for_each_device class_find_device class_for_each_child class_find_child Signed-off-by: Dave Young [EMAIL PROTECTED] --- drivers/base/class.c | 159 + include/linux/device.h |

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-15 Thread Cornelia Huck
On Tue, 15 Jan 2008 17:13:22 +0800, Dave Young [EMAIL PROTECTED] wrote: Add the following class iteration functions for driver use: class_for_each_device class_find_device class_for_each_child class_find_child Signed-off-by: Dave Young [EMAIL PROTECTED] Acked-by: Cornelia Huck [EMAIL

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-14 Thread Dave Young
On Jan 14, 2008 8:13 PM, Cornelia Huck <[EMAIL PROTECTED]> wrote: > On Sat, 12 Jan 2008 17:47:54 +0800, > Dave Young <[EMAIL PROTECTED]> wrote: > > Minor style suggestion (same for class_find_child): > > > +struct device *class_find_device(struct class *class, void *data, > > +

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-14 Thread Cornelia Huck
On Sat, 12 Jan 2008 17:47:54 +0800, Dave Young <[EMAIL PROTECTED]> wrote: Minor style suggestion (same for class_find_child): > +struct device *class_find_device(struct class *class, void *data, > +int (*match)(struct device *, void *)) > +{ > + struct device

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-14 Thread Cornelia Huck
On Sat, 12 Jan 2008 17:47:54 +0800, Dave Young [EMAIL PROTECTED] wrote: Minor style suggestion (same for class_find_child): +struct device *class_find_device(struct class *class, void *data, +int (*match)(struct device *, void *)) +{ + struct device *dev;

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-14 Thread Dave Young
On Jan 14, 2008 8:13 PM, Cornelia Huck [EMAIL PROTECTED] wrote: On Sat, 12 Jan 2008 17:47:54 +0800, Dave Young [EMAIL PROTECTED] wrote: Minor style suggestion (same for class_find_child): +struct device *class_find_device(struct class *class, void *data, +

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Dave Young
On Jan 14, 2008 2:58 PM, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On Mon, Jan 14, 2008 at 09:36:04AM +0800, Dave Young wrote: > > On Jan 13, 2008 4:11 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > ... > > > Probably some tiny oversight, but I see this comment to struct class > > > doesn't

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Jarek Poplawski
On Mon, Jan 14, 2008 at 09:36:04AM +0800, Dave Young wrote: > On Jan 13, 2008 4:11 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote: ... > > Probably some tiny oversight, but I see this comment to struct class > > doesn't mention devices list, so maybe this needs to be updated BTW?: > > > > (from

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Dave Young
On Jan 13, 2008 4:11 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > On Sat, Jan 12, 2008 at 05:47:54PM +0800, Dave Young wrote: > > Add the following class iteration functions for driver use: > > class_for_each_device > > class_find_device > > class_for_each_child > > class_find_child > > > >

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Dave Young
On Jan 12, 2008 6:50 PM, Stefan Richter <[EMAIL PROTECTED]> wrote: > Dave Young wrote: > > Add the following class iteration functions for driver use: > > Thanks Dave. I will check the ieee1394 part in detail later. > > ... > > +/** > > + * class_find_device - device iterator for locating a

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Dave Young
On Jan 12, 2008 6:50 PM, Stefan Richter [EMAIL PROTECTED] wrote: Dave Young wrote: Add the following class iteration functions for driver use: Thanks Dave. I will check the ieee1394 part in detail later. ... +/** + * class_find_device - device iterator for locating a particular device

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Dave Young
On Jan 13, 2008 4:11 AM, Jarek Poplawski [EMAIL PROTECTED] wrote: On Sat, Jan 12, 2008 at 05:47:54PM +0800, Dave Young wrote: Add the following class iteration functions for driver use: class_for_each_device class_find_device class_for_each_child class_find_child Signed-off-by:

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Jarek Poplawski
On Mon, Jan 14, 2008 at 09:36:04AM +0800, Dave Young wrote: On Jan 13, 2008 4:11 AM, Jarek Poplawski [EMAIL PROTECTED] wrote: ... Probably some tiny oversight, but I see this comment to struct class doesn't mention devices list, so maybe this needs to be updated BTW?: (from

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-13 Thread Dave Young
On Jan 14, 2008 2:58 PM, Jarek Poplawski [EMAIL PROTECTED] wrote: On Mon, Jan 14, 2008 at 09:36:04AM +0800, Dave Young wrote: On Jan 13, 2008 4:11 AM, Jarek Poplawski [EMAIL PROTECTED] wrote: ... Probably some tiny oversight, but I see this comment to struct class doesn't mention devices

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-12 Thread Jarek Poplawski
On Sat, Jan 12, 2008 at 05:47:54PM +0800, Dave Young wrote: > Add the following class iteration functions for driver use: > class_for_each_device > class_find_device > class_for_each_child > class_find_child > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> > > --- > drivers/base/class.c |

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-12 Thread Stefan Richter
Dave Young wrote: > Add the following class iteration functions for driver use: Thanks Dave. I will check the ieee1394 part in detail later. ... > +/** > + * class_find_device - device iterator for locating a particular device > + * @class: the class we're iterating > + * @data: data for the

[PATCH 1/7] driver-core : add class iteration api

2008-01-12 Thread Dave Young
Add the following class iteration functions for driver use: class_for_each_device class_find_device class_for_each_child class_find_child Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- drivers/base/class.c | 159 + include/linux/device.h |

[PATCH 1/7] driver-core : add class iteration api

2008-01-12 Thread Dave Young
Add the following class iteration functions for driver use: class_for_each_device class_find_device class_for_each_child class_find_child Signed-off-by: Dave Young [EMAIL PROTECTED] --- drivers/base/class.c | 159 + include/linux/device.h |

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-12 Thread Stefan Richter
Dave Young wrote: Add the following class iteration functions for driver use: Thanks Dave. I will check the ieee1394 part in detail later. ... +/** + * class_find_device - device iterator for locating a particular device + * @class: the class we're iterating + * @data: data for the match

Re: [PATCH 1/7] driver-core : add class iteration api

2008-01-12 Thread Jarek Poplawski
On Sat, Jan 12, 2008 at 05:47:54PM +0800, Dave Young wrote: Add the following class iteration functions for driver use: class_for_each_device class_find_device class_for_each_child class_find_child Signed-off-by: Dave Young [EMAIL PROTECTED] --- drivers/base/class.c | 159