Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-09 Thread Vineeth Pillai
On 4/8/21 11:24 AM, Sean Christopherson wrote: Technically, you can use normal memory accesses, so long as software guarantees the VMCS isn't resident in the VMCS cache and knows the field offsets for the underlying CPU. The lack of an architecturally defined layout is the biggest issue,

Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-08 Thread Sean Christopherson
On Thu, Apr 08, 2021, Vineeth Pillai wrote: > Hi Vitaly, > > On 4/8/21 7:06 AM, Vitaly Kuznetsov wrote: > > - if (ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED) { > > + /* > > +* AMD does not need enlightened VMCS as VMCB is already a > > +* datastructure in memory. > > Well,

Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-08 Thread Vineeth Pillai
On 4/7/21 6:48 PM, Sean Christopherson wrote: On Wed, Apr 07, 2021, Michael Kelley wrote: + pr_info("Hyper-V nested_features: 0x%x\n", Nit: Most other similar lines put the colon in a different place: pr_info("Hyper-V: nested features 0x%x\n", One of these

Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-08 Thread Vineeth Pillai
Hi Vitaly, On 4/8/21 7:06 AM, Vitaly Kuznetsov wrote: - if (ms_hyperv.hints & HV_X64_ENLIGHTENED_VMCS_RECOMMENDED) { + /* +* AMD does not need enlightened VMCS as VMCB is already a +* datastructure in memory. Well, VMCS is also a structure in memory, isn't it? It's

Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-08 Thread Vitaly Kuznetsov
Vineeth Pillai writes: > Detect nested features exposed by Hyper-V if SVM is enabled. > > Signed-off-by: Vineeth Pillai > --- > arch/x86/kernel/cpu/mshyperv.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/mshyperv.c

Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-07 Thread Sean Christopherson
On Wed, Apr 07, 2021, Michael Kelley wrote: > From: Vineeth Pillai Sent: Wednesday, April 7, > 2021 7:41 AM > > > > Detect nested features exposed by Hyper-V if SVM is enabled. > > > > Signed-off-by: Vineeth Pillai > > --- > > arch/x86/kernel/cpu/mshyperv.c | 10 +- > > 1 file

RE: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-07 Thread Michael Kelley
From: Vineeth Pillai Sent: Wednesday, April 7, 2021 7:41 AM > > Detect nested features exposed by Hyper-V if SVM is enabled. > > Signed-off-by: Vineeth Pillai > --- > arch/x86/kernel/cpu/mshyperv.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-07 Thread Borislav Petkov
On Wed, Apr 07, 2021 at 02:41:22PM +, Vineeth Pillai wrote: > Detect nested features exposed by Hyper-V if SVM is enabled. > > Signed-off-by: Vineeth Pillai > --- > arch/x86/kernel/cpu/mshyperv.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git

[PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-07 Thread Vineeth Pillai
Detect nested features exposed by Hyper-V if SVM is enabled. Signed-off-by: Vineeth Pillai --- arch/x86/kernel/cpu/mshyperv.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index