Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2014-01-15 Thread Florian Vaussard
Hi Suman, So back to this... On 12/24/2013 12:35 AM, Anna, Suman wrote: > Hi Florian, > [...] >> >> If omap_iommu_probe() fails, the init will have called bus_set_iommu() >> anyways. Thus, when a driver request the iommu by calling >> iommu_domain_alloc(), it will succeed (but iommu_attach_dev

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: Currently, bus_set_iommu() is done in omap_iommu_init(). However, omap_iommu_probe() can fail in a number of ways, leaving the platform bus with a dangling reference to a non-initialized iommu. Perform bus_set_iommu() only if omap_iom

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:02 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> Currently, bus_set_iommu() is done in omap_iommu_init(). However, >> omap_iommu_probe() can fail in a number of ways, leaving the platform >> bus with a dangling reference to

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-23 Thread Anna, Suman
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: Currently, bus_set_iommu() is done in omap_iommu_init(). However, omap_iommu_probe() can fail in a number of ways, leaving the platform bus with a dangling reference to a non-initialized iommu. Perform bus_set_iommu() only if omap_iommu

[PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-17 Thread Florian Vaussard
Currently, bus_set_iommu() is done in omap_iommu_init(). However, omap_iommu_probe() can fail in a number of ways, leaving the platform bus with a dangling reference to a non-initialized iommu. Perform bus_set_iommu() only if omap_iommu_probe() succeed. Signed-off-by: Florian Vaussard --- driver