Re: [PATCH 1/7] k3dma: Fix hisi burst clipping

2016-08-04 Thread Vinod Koul
On Thu, Aug 04, 2016 at 10:36:32AM -0700, John Stultz wrote: > On Thu, Aug 4, 2016 at 6:08 AM, Vinod Koul wrote: > > On Fri, Jul 29, 2016 at 03:40:46PM -0700, John Stultz wrote: > >> On Sun, Jul 24, 2016 at 12:25 AM, Vinod Koul wrote: > >> > On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz w

Re: [PATCH 1/7] k3dma: Fix hisi burst clipping

2016-08-04 Thread John Stultz
On Thu, Aug 4, 2016 at 6:08 AM, Vinod Koul wrote: > On Fri, Jul 29, 2016 at 03:40:46PM -0700, John Stultz wrote: >> On Sun, Jul 24, 2016 at 12:25 AM, Vinod Koul wrote: >> > On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz wrote: >> >> From: Andy Green >> >> >> >> Max burst len is a 4-bit fi

Re: [PATCH 1/7] k3dma: Fix hisi burst clipping

2016-08-04 Thread Vinod Koul
On Fri, Jul 29, 2016 at 03:40:46PM -0700, John Stultz wrote: > On Sun, Jul 24, 2016 at 12:25 AM, Vinod Koul wrote: > > On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz wrote: > >> From: Andy Green > >> > >> Max burst len is a 4-bit field, but at the moment it's clipped with > >> a 5-bit cons

Re: [PATCH 1/7] k3dma: Fix hisi burst clipping

2016-07-29 Thread John Stultz
On Sun, Jul 24, 2016 at 12:25 AM, Vinod Koul wrote: > On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz wrote: >> From: Andy Green >> >> Max burst len is a 4-bit field, but at the moment it's clipped with >> a 5-bit constant... reduce it to that which can be expressed > > Maybe we should GENM

Re: [PATCH 1/7] k3dma: Fix hisi burst clipping

2016-07-24 Thread Vinod Koul
On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz wrote: > From: Andy Green > > Max burst len is a 4-bit field, but at the moment it's clipped with > a 5-bit constant... reduce it to that which can be expressed Maybe we should GENMASK() etc to avoid these errors.. > if ((maxburst == 0

[PATCH 1/7] k3dma: Fix hisi burst clipping

2016-07-20 Thread John Stultz
From: Andy Green Max burst len is a 4-bit field, but at the moment it's clipped with a 5-bit constant... reduce it to that which can be expressed Cc: Zhangfei Gao Cc: Jingoo Han Cc: Krzysztof Kozlowski Cc: Maxime Ripard Cc: Vinod Koul Cc: Dan Williams Cc: Mark Brown Cc: Andy Green Acked-

Re: [RFC][PATCH 1/7] k3dma: Fix hisi burst clipping

2016-07-17 Thread zhangfei
On 07/16/2016 10:13 AM, John Stultz wrote: From: Andy Green Max burst len is a 4-bit field, but at the moment it's clipped with a 5-bit constant... reduce it to that which can be expressed Cc: Zhangfei Gao Cc: Jingoo Han Cc: Krzysztof Kozlowski Cc: Maxime Ripard Cc: Vinod Koul Cc: Dan W

[RFC][PATCH 1/7] k3dma: Fix hisi burst clipping

2016-07-15 Thread John Stultz
From: Andy Green Max burst len is a 4-bit field, but at the moment it's clipped with a 5-bit constant... reduce it to that which can be expressed Cc: Zhangfei Gao Cc: Jingoo Han Cc: Krzysztof Kozlowski Cc: Maxime Ripard Cc: Vinod Koul Cc: Dan Williams Cc: Liam Girdwood Cc: Mark Brown Cc: