Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-09 Thread Paul Bolle
Hi Masahiro, On do, 2015-07-09 at 14:32 +0900, Masahiro Yamada wrote: > After I read your references and thought a bit more, > I am now considering to change the bool into tristate. > > [...] > > Is this OK with you? Whether this should be bool or tristate is up to you and the maintainer

Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-09 Thread Paul Bolle
Hi Masahiro, On do, 2015-07-09 at 14:32 +0900, Masahiro Yamada wrote: After I read your references and thought a bit more, I am now considering to change the bool into tristate. [...] Is this OK with you? Whether this should be bool or tristate is up to you and the maintainer (Linus?). I

Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-08 Thread Masahiro Yamada
Hi Paul, 2015-07-09 5:39 GMT+09:00 Paul Bolle : > Hi Masahiro, > > On wo, 2015-07-08 at 14:01 +0900, Masahiro Yamada wrote: >> Actually, most of pinctrl drivers are boolean, but most of them >> conventionally have MODULE_AUTHOR, THIS_MODULE, etc. >> >> I do not think it looks so weird. Thought?

Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-08 Thread Paul Bolle
Hi Masahiro, On wo, 2015-07-08 at 14:01 +0900, Masahiro Yamada wrote: > Actually, most of pinctrl drivers are boolean, but most of them > conventionally have MODULE_AUTHOR, THIS_MODULE, etc. > > I do not think it looks so weird. Thought? It's a rather common pattern, but I think it's an

Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-08 Thread Paul Bolle
Hi Masahiro, On wo, 2015-07-08 at 14:01 +0900, Masahiro Yamada wrote: Actually, most of pinctrl drivers are boolean, but most of them conventionally have MODULE_AUTHOR, THIS_MODULE, etc. I do not think it looks so weird. Thought? It's a rather common pattern, but I think it's an

Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-08 Thread Masahiro Yamada
Hi Paul, 2015-07-09 5:39 GMT+09:00 Paul Bolle pebo...@tiscali.nl: Hi Masahiro, On wo, 2015-07-08 at 14:01 +0900, Masahiro Yamada wrote: Actually, most of pinctrl drivers are boolean, but most of them conventionally have MODULE_AUTHOR, THIS_MODULE, etc. I do not think it looks so weird.

Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-07 Thread Masahiro Yamada
Hi Paul, 2015-07-07 18:14 GMT+09:00 Paul Bolle : > (I only comment on 1/7, because it's not useful to repeat one remark > seven times.) > > On ma, 2015-07-06 at 21:29 +0900, Masahiro Yamada wrote: >> --- /dev/null >> +++ b/drivers/pinctrl/uniphier/Kconfig > >> +config PINCTRL_UNIPHIER_CORE >> +

Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-07 Thread Paul Bolle
(I only comment on 1/7, because it's not useful to repeat one remark seven times.) On ma, 2015-07-06 at 21:29 +0900, Masahiro Yamada wrote: > --- /dev/null > +++ b/drivers/pinctrl/uniphier/Kconfig > +config PINCTRL_UNIPHIER_CORE > + bool > + select PINMUX > + select GENERIC_PINCONF

Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-07 Thread Paul Bolle
(I only comment on 1/7, because it's not useful to repeat one remark seven times.) On ma, 2015-07-06 at 21:29 +0900, Masahiro Yamada wrote: --- /dev/null +++ b/drivers/pinctrl/uniphier/Kconfig +config PINCTRL_UNIPHIER_CORE + bool + select PINMUX + select GENERIC_PINCONF ---

Re: [PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-07 Thread Masahiro Yamada
Hi Paul, 2015-07-07 18:14 GMT+09:00 Paul Bolle pebo...@tiscali.nl: (I only comment on 1/7, because it's not useful to repeat one remark seven times.) On ma, 2015-07-06 at 21:29 +0900, Masahiro Yamada wrote: --- /dev/null +++ b/drivers/pinctrl/uniphier/Kconfig +config

[PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-06 Thread Masahiro Yamada
The core support for the pinctrl drivers for all the UniPhier SoCs. Signed-off-by: Masahiro Yamada --- drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/uniphier/Kconfig | 8 +

[PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

2015-07-06 Thread Masahiro Yamada
The core support for the pinctrl drivers for all the UniPhier SoCs. Signed-off-by: Masahiro Yamada yamada.masah...@socionext.com --- drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/uniphier/Kconfig