Re: [PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-04 Thread Kent Gibson
On Mon, Jan 04, 2021 at 11:00:31PM +0800, Kent Gibson wrote: > On Mon, Jan 04, 2021 at 03:52:49PM +0200, Andy Shevchenko wrote: > > On Mon, Jan 4, 2021 at 3:51 AM Kent Gibson wrote: > > > On Sun, Jan 03, 2021 at 05:10:10PM +0200, Andy Shevchenko wrote: > > > > ... > > > > > In this example it is

Re: [PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-04 Thread Kent Gibson
On Mon, Jan 04, 2021 at 03:52:49PM +0200, Andy Shevchenko wrote: > On Mon, Jan 4, 2021 at 3:51 AM Kent Gibson wrote: > > On Sun, Jan 03, 2021 at 05:10:10PM +0200, Andy Shevchenko wrote: > > ... > > > In this example it is the 508: > > > > # e.g. gpiochip0: GPIOs 508-511, parent: platform/gpio-mo

Re: [PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-04 Thread Andy Shevchenko
On Mon, Jan 4, 2021 at 3:51 AM Kent Gibson wrote: > On Sun, Jan 03, 2021 at 05:10:10PM +0200, Andy Shevchenko wrote: ... > In this example it is the 508: > > # e.g. gpiochip0: GPIOs 508-511, parent: platform/gpio-mockup.0, > gpio-mockup-A: > > So I'll use that - unless it is unreliable for some

Re: [PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-03 Thread Kent Gibson
On Sun, Jan 03, 2021 at 05:10:10PM +0200, Andy Shevchenko wrote: > On Sun, Jan 3, 2021 at 4:17 AM Kent Gibson wrote: > > On Sun, Jan 03, 2021 at 12:20:26AM +0200, Andy Shevchenko wrote: > > > On Sat, Jan 2, 2021 at 4:32 AM Kent Gibson wrote: > [snip] > > ... > > > > > + local platform=`c

Re: [PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-03 Thread Kent Gibson
On Sun, Jan 03, 2021 at 05:10:10PM +0200, Andy Shevchenko wrote: > On Sun, Jan 3, 2021 at 4:17 AM Kent Gibson wrote: > > On Sun, Jan 03, 2021 at 12:20:26AM +0200, Andy Shevchenko wrote: > > > On Sat, Jan 2, 2021 at 4:32 AM Kent Gibson wrote: > > ... > > > > > +#include > > > > > > Perhaps incl

Re: [PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-03 Thread Andy Shevchenko
On Sun, Jan 3, 2021 at 4:17 AM Kent Gibson wrote: > On Sun, Jan 03, 2021 at 12:20:26AM +0200, Andy Shevchenko wrote: > > On Sat, Jan 2, 2021 at 4:32 AM Kent Gibson wrote: ... > > > +#include > > > > Perhaps include it after system headers? > > hehe, I blindly sorted them. > Should it matter?

Re: [PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-02 Thread Kent Gibson
On Sun, Jan 03, 2021 at 12:20:26AM +0200, Andy Shevchenko wrote: > On Sat, Jan 2, 2021 at 4:32 AM Kent Gibson wrote: > > > > The GPIO mockup selftests are overly complicated with separate > > implementations of the tests for sysfs and cdev uAPI, and with the cdev > > implementation being dependent

Re: [PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-02 Thread Andy Shevchenko
On Sat, Jan 2, 2021 at 4:32 AM Kent Gibson wrote: > > The GPIO mockup selftests are overly complicated with separate > implementations of the tests for sysfs and cdev uAPI, and with the cdev > implementation being dependent on tools/gpio and libmount. > > Rework the test implementation to provide

Re: [PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-02 Thread Kent Gibson
On Sat, Jan 02, 2021 at 03:52:32PM +0200, Andy Shevchenko wrote: > On Saturday, January 2, 2021, Kent Gibson wrote: > > > The GPIO mockup selftests are overly complicated with separate > > implementations of the tests for sysfs and cdev uAPI, and with the cdev > > implementation being dependent o

[PATCH 1/7] selftests: gpio: rework and simplify test implementation

2021-01-01 Thread Kent Gibson
The GPIO mockup selftests are overly complicated with separate implementations of the tests for sysfs and cdev uAPI, and with the cdev implementation being dependent on tools/gpio and libmount. Rework the test implementation to provide a common test suite with a simplified pluggable uAPI interface