Re: [PATCH 1/7] trace: Move trace_seq_overflowed out of line

On Wed, 15 Mar 2017 23:20:30 -0400 Steven Rostedt wrote: > > It is used in lots of places outside trace_handle_return, so that would > > give far less savings. Actually, I think you'll probably have *more* savings inlining trace_handle_return() than

Re: [PATCH 1/7] trace: Move trace_seq_overflowed out of line

On Wed, 15 Mar 2017 23:20:30 -0400 Steven Rostedt wrote: > > It is used in lots of places outside trace_handle_return, so that would > > give far less savings. Actually, I think you'll probably have *more* savings inlining trace_handle_return() than trace_seq_has_overflowed(). Why? Think

Re: [PATCH 1/7] trace: Move trace_seq_overflowed out of line

On Wed, 15 Mar 2017 19:27:57 -0700 Andi Kleen wrote: > On Wed, Mar 15, 2017 at 08:54:20PM -0400, Steven Rostedt wrote: > > On Tue, 14 Mar 2017 19:14:25 -0700 > > Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > >

Re: [PATCH 1/7] trace: Move trace_seq_overflowed out of line

On Wed, 15 Mar 2017 19:27:57 -0700 Andi Kleen wrote: > On Wed, Mar 15, 2017 at 08:54:20PM -0400, Steven Rostedt wrote: > > On Tue, 14 Mar 2017 19:14:25 -0700 > > Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > Inlining trace_seq_overflowed takes ~17k in text size in my kernel. > >

Re: [PATCH 1/7] trace: Move trace_seq_overflowed out of line

On Wed, Mar 15, 2017 at 08:54:20PM -0400, Steven Rostedt wrote: > On Tue, 14 Mar 2017 19:14:25 -0700 > Andi Kleen wrote: > > > From: Andi Kleen > > > > Inlining trace_seq_overflowed takes ~17k in text size in my kernel. > > The function doesn't seem

Re: [PATCH 1/7] trace: Move trace_seq_overflowed out of line

On Wed, Mar 15, 2017 at 08:54:20PM -0400, Steven Rostedt wrote: > On Tue, 14 Mar 2017 19:14:25 -0700 > Andi Kleen wrote: > > > From: Andi Kleen > > > > Inlining trace_seq_overflowed takes ~17k in text size in my kernel. > > The function doesn't seem to be time critical, so we can just out of

Re: [PATCH 1/7] trace: Move trace_seq_overflowed out of line

On Tue, 14 Mar 2017 19:14:25 -0700 Andi Kleen wrote: > From: Andi Kleen > > Inlining trace_seq_overflowed takes ~17k in text size in my kernel. > The function doesn't seem to be time critical, so we can just out of line it. Instead of out of lining

Re: [PATCH 1/7] trace: Move trace_seq_overflowed out of line

On Tue, 14 Mar 2017 19:14:25 -0700 Andi Kleen wrote: > From: Andi Kleen > > Inlining trace_seq_overflowed takes ~17k in text size in my kernel. > The function doesn't seem to be time critical, so we can just out of line it. Instead of out of lining trace_seq_has_overflowed(), have you tried

[PATCH 1/7] trace: Move trace_seq_overflowed out of line

From: Andi Kleen Inlining trace_seq_overflowed takes ~17k in text size in my kernel. The function doesn't seem to be time critical, so we can just out of line it. Function Total Avg Num trace_seq_has_overflowed

[PATCH 1/7] trace: Move trace_seq_overflowed out of line

From: Andi Kleen Inlining trace_seq_overflowed takes ~17k in text size in my kernel. The function doesn't seem to be time critical, so we can just out of line it. Function Total Avg Num trace_seq_has_overflowed 17134