Re: [PATCH 1/8] LinuxPPS core support.

2008-02-11 Thread Rodolfo Giometti
On Mon, Feb 11, 2008 at 07:31:53PM +0100, Rodolfo Giometti wrote: > Do you think is better create these files anyway and in case report a > NULL string? Is that ok? /* * Attribute functions */ static ssize_t pps_show_assert(struct device *dev, struct device_attr

Re: [PATCH 1/8] LinuxPPS core support.

2008-02-11 Thread Rodolfo Giometti
On Mon, Feb 11, 2008 at 07:25:42AM -0800, Greg KH wrote: > On Mon, Feb 11, 2008 at 10:53:46AM +0100, Rodolfo Giometti wrote: > > On Fri, Feb 08, 2008 at 10:45:31PM -0800, Greg KH wrote: > > > > > > As you are adding sysfs files, please also describe them in > > > Documentation/ABI/ in this same se

Re: [PATCH 1/8] LinuxPPS core support.

2008-02-11 Thread Greg KH
On Mon, Feb 11, 2008 at 10:53:46AM +0100, Rodolfo Giometti wrote: > On Fri, Feb 08, 2008 at 10:45:31PM -0800, Greg KH wrote: > > > > As you are adding sysfs files, please also describe them in > > Documentation/ABI/ in this same series of patches. > > Ok. I'm going to add them under "testing". >

Re: [PATCH 1/8] LinuxPPS core support.

2008-02-11 Thread Rodolfo Giometti
On Fri, Feb 08, 2008 at 10:45:31PM -0800, Greg KH wrote: > > As you are adding sysfs files, please also describe them in > Documentation/ABI/ in this same series of patches. Ok. I'm going to add them under "testing". > Why not use a default attribute group? > > That way the files are created be

Re: [PATCH 1/8] LinuxPPS core support.

2008-02-08 Thread Greg KH
On Fri, Feb 08, 2008 at 07:00:37PM +0100, Rodolfo Giometti wrote: > This patch adds the kernel side of the PPS support currently named > "LinuxPPS". > > PPS means "pulse per second" and a PPS source is just a device which > provides a high precision signal each second so that an application > can

Re: [PATCH 1/8] LinuxPPS core support.

2008-02-08 Thread Sam Ravnborg
Hi Rodolfo. Kconfig bits are trivial and looks OK. > diff --git a/drivers/pps/Makefile b/drivers/pps/Makefile > new file mode 100644 > index 000..5a9a51b > --- /dev/null > +++ b/drivers/pps/Makefile > @@ -0,0 +1,10 @@ > +# > +# Makefile for the PPS core. > +# > + > +pps_core-objs

[PATCH 1/8] LinuxPPS core support.

2008-02-08 Thread Rodolfo Giometti
This patch adds the kernel side of the PPS support currently named "LinuxPPS". PPS means "pulse per second" and a PPS source is just a device which provides a high precision signal each second so that an application can use it to adjust system clock time. Common use is the combination of the NTPD