Re: [PATCH 1/8] compacting file_ra_state

2007-07-20 Thread Andi Kleen
On Fri, Jul 20, 2007 at 11:13:34PM -0700, Linus Torvalds wrote: > > I thought the new patches were some some restructured code, but > > essentially the tested algorithms? > > No, this series is a further cleanup on top of the restructured code, with > some new features too. The series _looks_ fi

Re: [PATCH 1/8] compacting file_ra_state

2007-07-20 Thread Linus Torvalds
On Sat, 21 Jul 2007, Andi Kleen wrote: > > Haven't the readahead patches already essentially been in -mm* for some time? They have indeed, and I merged them this week. > I thought the new patches were some some restructured code, but > essentially the tested algorithms? No, this series is a

Re: [PATCH 1/8] compacting file_ra_state

2007-07-20 Thread Andrew Morton
On Sat, 21 Jul 2007 07:57:06 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Fri, Jul 20, 2007 at 09:27:01PM -0700, Linus Torvalds wrote: > > > > > > On Sat, 21 Jul 2007, Fengguang Wu wrote: > > > > > > Sorry, forgot to prefix the patch titles with [readahead]. > > > Should I repost? > > > > N

Re: [PATCH 1/8] compacting file_ra_state

2007-07-20 Thread Andi Kleen
On Fri, Jul 20, 2007 at 09:27:01PM -0700, Linus Torvalds wrote: > > > On Sat, 21 Jul 2007, Fengguang Wu wrote: > > > > Sorry, forgot to prefix the patch titles with [readahead]. > > Should I repost? > > Not for me, but on the other hand, I'd prefer for this to be in -mm a bit, Haven't the read

Re: [PATCH 1/8] compacting file_ra_state

2007-07-20 Thread Fengguang Wu
On Fri, Jul 20, 2007 at 09:27:01PM -0700, Linus Torvalds wrote: > > > On Sat, 21 Jul 2007, Fengguang Wu wrote: > > > > Sorry, forgot to prefix the patch titles with [readahead]. > > Should I repost? > > Not for me, but on the other hand, I'd prefer for this to be in -mm a bit, > even if it does

Re: [PATCH 1/8] compacting file_ra_state

2007-07-20 Thread Linus Torvalds
On Sat, 21 Jul 2007, Fengguang Wu wrote: > > Sorry, forgot to prefix the patch titles with [readahead]. > Should I repost? Not for me, but on the other hand, I'd prefer for this to be in -mm a bit, even if it does mean missing the merge window this time around. Linus - To unsu

Re: [PATCH 1/8] compacting file_ra_state

2007-07-20 Thread Fengguang Wu
Sorry, forgot to prefix the patch titles with [readahead]. Should I repost? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.

[PATCH 1/8] compacting file_ra_state

2007-07-20 Thread Fengguang Wu
Use 'unsigned int' instead of 'unsigned long' for readahead sizes. This helps reduce memory consumption on 64bit CPU when a lot of files are opened. CC: Andi Kleen <[EMAIL PROTECTED]> Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- include/linux/fs.h |8 mm/readahead.c |