Re: [PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-09 Thread Viresh Kumar
On 09-07-20, 09:53, Ionela Voinescu wrote: > On Monday 06 Jul 2020 at 14:14:47 (+0200), Dietmar Eggemann wrote: > > Why can't we just move the arch_set_freq_scale() call from cpufreq > > driver to cpufreq core w/o introducing a FIE related driver flag? > > > > Current scenario for Frequency Invari

Re: [PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-09 Thread Ionela Voinescu
Hi guys, On Monday 06 Jul 2020 at 14:14:47 (+0200), Dietmar Eggemann wrote: > On 02/07/2020 13:44, Ionela Voinescu wrote: > > Hi, > > > > On Thursday 02 Jul 2020 at 08:28:18 (+0530), Viresh Kumar wrote: > >> On 01-07-20, 18:05, Rafael J. Wysocki wrote: > >>> On Wed, Jul 1, 2020 at 3:33 PM Ionela

Re: [PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-06 Thread Dietmar Eggemann
On 02/07/2020 13:44, Ionela Voinescu wrote: > Hi, > > On Thursday 02 Jul 2020 at 08:28:18 (+0530), Viresh Kumar wrote: >> On 01-07-20, 18:05, Rafael J. Wysocki wrote: >>> On Wed, Jul 1, 2020 at 3:33 PM Ionela Voinescu >>> wrote: On Wednesday 01 Jul 2020 at 16:16:17 (+0530), Viresh Kumar wro

Re: [PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-02 Thread Ionela Voinescu
Hi, On Thursday 02 Jul 2020 at 08:28:18 (+0530), Viresh Kumar wrote: > On 01-07-20, 18:05, Rafael J. Wysocki wrote: > > On Wed, Jul 1, 2020 at 3:33 PM Ionela Voinescu > > wrote: > > > On Wednesday 01 Jul 2020 at 16:16:17 (+0530), Viresh Kumar wrote: > > > > I will rather suggest CPUFREQ_SKIP_SET

Re: [PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-01 Thread Viresh Kumar
On 01-07-20, 18:05, Rafael J. Wysocki wrote: > On Wed, Jul 1, 2020 at 3:33 PM Ionela Voinescu > wrote: > > On Wednesday 01 Jul 2020 at 16:16:17 (+0530), Viresh Kumar wrote: > > > I will rather suggest CPUFREQ_SKIP_SET_FREQ_SCALE as the name and > > > functionality. We need to give drivers a choic

Re: [PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-01 Thread Ionela Voinescu
Hi Rafael, Thank you for the review! On Wednesday 01 Jul 2020 at 18:05:33 (+0200), Rafael J. Wysocki wrote: > On Wed, Jul 1, 2020 at 3:33 PM Ionela Voinescu > wrote: > > > > Hi, > > > > Thank you for taking a look over these so quickly. > > > > On Wednesday 01 Jul 2020 at 16:16:17 (+0530), Vire

Re: [PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-01 Thread Rafael J. Wysocki
On Wed, Jul 1, 2020 at 3:33 PM Ionela Voinescu wrote: > > Hi, > > Thank you for taking a look over these so quickly. > > On Wednesday 01 Jul 2020 at 16:16:17 (+0530), Viresh Kumar wrote: > > On 01-07-20, 10:07, Ionela Voinescu wrote: > > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufr

Re: [PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-01 Thread Ionela Voinescu
Hi, Thank you for taking a look over these so quickly. On Wednesday 01 Jul 2020 at 16:16:17 (+0530), Viresh Kumar wrote: > On 01-07-20, 10:07, Ionela Voinescu wrote: > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > > index 3494f6763597..42668588f9f8 100644 > > --- a/include/li

Re: [PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-01 Thread Viresh Kumar
On 01-07-20, 10:07, Ionela Voinescu wrote: > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > index 3494f6763597..42668588f9f8 100644 > --- a/include/linux/cpufreq.h > +++ b/include/linux/cpufreq.h > @@ -293,7 +293,7 @@ __ATTR(_name, 0644, show_##_name, store_##_name) > > struct

[PATCH 1/8] cpufreq: allow drivers to flag custom support for freq invariance

2020-07-01 Thread Ionela Voinescu
The scheduler's Frequency Invariance Engine (FIE) is providing a frequency scale correction factor that helps achieve more accurate load-tracking by conveying information about the currently selected frequency relative to the maximum supported frequency of a CPU. In some cases this is achieved by