Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data

2016-12-19 Thread Chanwoo Choi
Hi Hans, On 2016년 12월 19일 17:18, Hans de Goede wrote: > Hi, > > On 19-12-16 07:58, Chanwoo Choi wrote: >> Hi Hans, >> >> This series look good to me. I added the comment >> for patch4/5. If you agree following two comment, I'll merge these series >> for 4.11. >> >> - patch4 uses the EXTCON_NONE

Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data

2016-12-19 Thread Hans de Goede
Hi, On 19-12-16 07:58, Chanwoo Choi wrote: Hi Hans, This series look good to me. I added the comment for patch4/5. If you agree following two comment, I'll merge these series for 4.11. - patch4 uses the EXTCON_NONE when setting the previous_cable in probe() - patch5, I don't want to use the d

Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data

2016-12-18 Thread Chanwoo Choi
Hi Hans, This series look good to me. I added the comment for patch4/5. If you agree following two comment, I'll merge these series for 4.11. - patch4 uses the EXTCON_NONE when setting the previous_cable in probe() - patch5, I don't want to use the dev_info on the fly. So, I want to drop the pa

Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data

2016-12-18 Thread Chanwoo Choi
Hi Hans, On 2016년 12월 19일 09:13, Hans de Goede wrote: > When the extcon_axp288 driver was originally merged, it was merged with > a dependency on some other driver providing platform data for it. > > However such another driver was never merged, so the extcon_axp288 as > merged upstream has never

[PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data

2016-12-18 Thread Hans de Goede
When the extcon_axp288 driver was originally merged, it was merged with a dependency on some other driver providing platform data for it. However such another driver was never merged, so the extcon_axp288 as merged upstream has never worked, its probe method simply always returns -ENODEV. This co