Re: [PATCH 1/8] ftrace: add ftrace_init_nop()

2019-10-22 Thread Steven Rostedt
On Tue, 22 Oct 2019 16:33:35 +0100 Mark Rutland wrote: > On Tue, Oct 22, 2019 at 04:30:35PM +0100, Mark Rutland wrote: > > On Tue, Oct 22, 2019 at 08:54:28AM -0400, Steven Rostedt wrote: > > > On Tue, 22 Oct 2019 12:28:11 +0100 > > > Mark Rutland wrote: > > > > | /** > > > > | *

Re: [PATCH 1/8] ftrace: add ftrace_init_nop()

2019-10-22 Thread Mark Rutland
On Tue, Oct 22, 2019 at 04:30:35PM +0100, Mark Rutland wrote: > On Tue, Oct 22, 2019 at 08:54:28AM -0400, Steven Rostedt wrote: > > On Tue, 22 Oct 2019 12:28:11 +0100 > > Mark Rutland wrote: > > > | /** > > > | * ftrace_init_nop - initialize a nop call site > > > | * @mod: module structure if

Re: [PATCH 1/8] ftrace: add ftrace_init_nop()

2019-10-22 Thread Mark Rutland
On Tue, Oct 22, 2019 at 08:54:28AM -0400, Steven Rostedt wrote: > On Tue, 22 Oct 2019 12:28:11 +0100 > Mark Rutland wrote: > > > To make the name even better, let's just rename it to: > > > > > > ftrace_nop_initialization() > > > > > > I think that may be the best description for it. > > >

Re: [PATCH 1/8] ftrace: add ftrace_init_nop()

2019-10-22 Thread Steven Rostedt
On Tue, 22 Oct 2019 12:28:11 +0100 Mark Rutland wrote: > > To make the name even better, let's just rename it to: > > > > ftrace_nop_initialization() > > > > I think that may be the best description for it. > > Perhaps ftrace_nop_initialize(), so that it's not a noun? > > I've made it

Re: [PATCH 1/8] ftrace: add ftrace_init_nop()

2019-10-22 Thread Mark Rutland
On Mon, Oct 21, 2019 at 02:07:56PM -0400, Steven Rostedt wrote: > On Mon, 21 Oct 2019 17:34:19 +0100 > Mark Rutland wrote: > > > Architectures may need to perform special initialization of ftrace > > callsites, and today they do so by special-casing ftrace_make_nop() when > > the expected branch

Re: [PATCH 1/8] ftrace: add ftrace_init_nop()

2019-10-21 Thread Steven Rostedt
On Mon, 21 Oct 2019 17:34:19 +0100 Mark Rutland wrote: > Architectures may need to perform special initialization of ftrace > callsites, and today they do so by special-casing ftrace_make_nop() when > the expected branch address is MCOUNT_ADDR. In some cases (e.g. for >

[PATCH 1/8] ftrace: add ftrace_init_nop()

2019-10-21 Thread Mark Rutland
Architectures may need to perform special initialization of ftrace callsites, and today they do so by special-casing ftrace_make_nop() when the expected branch address is MCOUNT_ADDR. In some cases (e.g. for patchable-function-entry), we don't have an mcount-like symbol and don't want a synthetic