Re: [PATCH 1/8] idr: fix overflow bug for the max-high layer

2014-04-18 Thread Tejun Heo
On Sat, Apr 19, 2014 at 01:08:46AM +0800, Lai Jiangshan wrote: > On Sat, Apr 19, 2014 at 12:29 AM, Tejun Heo wrote: > > Hello, > > Hi, > > Should I resend the patch with your updated changelog? > Or something else I need to do? Yeah, please resend with the description updated. > >> static

Re: [PATCH 1/8] idr: fix overflow bug for the max-high layer

2014-04-18 Thread Lai Jiangshan
On Sat, Apr 19, 2014 at 12:29 AM, Tejun Heo wrote: > Hello, Hi, Should I resend the patch with your updated changelog? Or something else I need to do? > > Subject: idr: fix overflow bug during maximum ID calculation at maximum height > > On Fri, Apr 18, 2014 at 08:49:48PM +0800, Lai Jiangshan

Re: [PATCH 1/8] idr: fix overflow bug for the max-high layer

2014-04-18 Thread Tejun Heo
Hello, Subject: idr: fix overflow bug during maximum ID calculation at maximum height On Fri, Apr 18, 2014 at 08:49:48PM +0800, Lai Jiangshan wrote: > In idr_replace(), when the top layer is the max-high layer(p->layer == 3), > The "(1 << n)" will overflow and the result is 0, it causes

[PATCH 1/8] idr: fix overflow bug for the max-high layer

2014-04-18 Thread Lai Jiangshan
In idr_replace(), when the top layer is the max-high layer(p->layer == 3), The "(1 << n)" will overflow and the result is 0, it causes idr_replace() return -EINVAL even the id is actually valid. The following test code shows it fails to replace the value for id=((1<<27)+42): static void

[PATCH 1/8] idr: fix overflow bug for the max-high layer

2014-04-18 Thread Lai Jiangshan
In idr_replace(), when the top layer is the max-high layer(p-layer == 3), The (1 n) will overflow and the result is 0, it causes idr_replace() return -EINVAL even the id is actually valid. The following test code shows it fails to replace the value for id=((127)+42): static void test5(void) {

Re: [PATCH 1/8] idr: fix overflow bug for the max-high layer

2014-04-18 Thread Tejun Heo
Hello, Subject: idr: fix overflow bug during maximum ID calculation at maximum height On Fri, Apr 18, 2014 at 08:49:48PM +0800, Lai Jiangshan wrote: In idr_replace(), when the top layer is the max-high layer(p-layer == 3), The (1 n) will overflow and the result is 0, it causes idr_replace()

Re: [PATCH 1/8] idr: fix overflow bug for the max-high layer

2014-04-18 Thread Lai Jiangshan
On Sat, Apr 19, 2014 at 12:29 AM, Tejun Heo t...@kernel.org wrote: Hello, Hi, Should I resend the patch with your updated changelog? Or something else I need to do? Subject: idr: fix overflow bug during maximum ID calculation at maximum height On Fri, Apr 18, 2014 at 08:49:48PM +0800, Lai

Re: [PATCH 1/8] idr: fix overflow bug for the max-high layer

2014-04-18 Thread Tejun Heo
On Sat, Apr 19, 2014 at 01:08:46AM +0800, Lai Jiangshan wrote: On Sat, Apr 19, 2014 at 12:29 AM, Tejun Heo t...@kernel.org wrote: Hello, Hi, Should I resend the patch with your updated changelog? Or something else I need to do? Yeah, please resend with the description updated. static