RE: [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init

2021-01-30 Thread Avri Altman
> On Sun, Jan 31, 2021 at 07:08:00AM +, Avri Altman wrote: > > > > > > > > +static enum UFSHPB_MODE ufshpb_mode; > > > > > > How are you allowed to have a single variable for a device-specific > > > thing? What happens when you have two controllers or disks or whatever > > > you are binding to

Re: [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init

2021-01-30 Thread Greg KH
On Sun, Jan 31, 2021 at 07:08:00AM +, Avri Altman wrote: > > > > > > +static enum UFSHPB_MODE ufshpb_mode; > > > > How are you allowed to have a single variable for a device-specific > > thing? What happens when you have two controllers or disks or whatever > > you are binding to here? How d

RE: [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init

2021-01-30 Thread Avri Altman
> > > > +static enum UFSHPB_MODE ufshpb_mode; > > How are you allowed to have a single variable for a device-specific > thing? What happens when you have two controllers or disks or whatever > you are binding to here? How does this work at all? > > This should be per-device, right? Right. Done.

[PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init

2021-01-27 Thread Avri Altman
We will use it later, when we'll need to differentiate between device and host control modes. Signed-off-by: Avri Altman --- drivers/scsi/ufs/ufshpb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index d3e6c5b323

Re: [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 05:12:10PM +0200, Avri Altman wrote: > We will use it later, when we'll need to differentiate between device > and host control modes. > > Signed-off-by: Avri Altman > --- > drivers/scsi/ufs/ufshpb.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff