> On Sun, Jan 31, 2021 at 07:08:00AM +, Avri Altman wrote:
> > > >
> > > > +static enum UFSHPB_MODE ufshpb_mode;
> > >
> > > How are you allowed to have a single variable for a device-specific
> > > thing? What happens when you have two controllers or disks or whatever
> > > you are binding to
On Sun, Jan 31, 2021 at 07:08:00AM +, Avri Altman wrote:
> > >
> > > +static enum UFSHPB_MODE ufshpb_mode;
> >
> > How are you allowed to have a single variable for a device-specific
> > thing? What happens when you have two controllers or disks or whatever
> > you are binding to here? How d
> >
> > +static enum UFSHPB_MODE ufshpb_mode;
>
> How are you allowed to have a single variable for a device-specific
> thing? What happens when you have two controllers or disks or whatever
> you are binding to here? How does this work at all?
>
> This should be per-device, right?
Right. Done.
We will use it later, when we'll need to differentiate between device
and host control modes.
Signed-off-by: Avri Altman
---
drivers/scsi/ufs/ufshpb.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index d3e6c5b323
On Wed, Jan 27, 2021 at 05:12:10PM +0200, Avri Altman wrote:
> We will use it later, when we'll need to differentiate between device
> and host control modes.
>
> Signed-off-by: Avri Altman
> ---
> drivers/scsi/ufs/ufshpb.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff
5 matches
Mail list logo