Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-09-03 Thread Moshe Green
On Fri, Sep 02, 2016 at 01:35:08PM +0200, Greg KH wrote: > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-09-03 Thread Moshe Green
On Fri, Sep 02, 2016 at 01:35:08PM +0200, Greg KH wrote: > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-09-02 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Sep 02, 2016 at

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-09-02 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Sep 02, 2016 at

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-09-02 Thread moshe green
There were (mostly) two kinds of warnings that I've handled, "80 character line length" and block comments structure. Some of the changes involve handling two separate warnings in a single comment. Where this occurs, should I break down the change into two steps - fixing a warning at a time? Or

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-09-02 Thread moshe green
There were (mostly) two kinds of warnings that I've handled, "80 character line length" and block comments structure. Some of the changes involve handling two separate warnings in a single comment. Where this occurs, should I break down the change into two steps - fixing a warning at a time? Or

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-09-01 Thread Greg KH
On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote: > Fix a line length warning found by the checkpatch.pl tool in > ddk750_chip.c. > > Signed-off-by: Moshe Green > --- > drivers/staging/sm750fb/ddk750_chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-09-01 Thread Greg KH
On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote: > Fix a line length warning found by the checkpatch.pl tool in > ddk750_chip.c. > > Signed-off-by: Moshe Green > --- > drivers/staging/sm750fb/ddk750_chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Lots of the patches

[PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-08-30 Thread Moshe Green
Fix a line length warning found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c

[PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-08-30 Thread Moshe Green
Fix a line length warning found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c