Re: [PATCH 1/9 v2] coresight: add CoreSight core layer framework

2014-07-15 Thread Mathieu Poirier
snip... >> +static void of_coresight_get_ports(struct device_node *node, >> + int *nr_inports, int *nr_outports) >> +{ >> + struct device_node *ep = NULL; >> + int in = 0, out = 0; >> + >> + do { >> + ep = of_get_coresight_endpoint(n

Re: [PATCH 1/9 v2] coresight: add CoreSight core layer framework

2014-07-03 Thread Daniel Thompson
On 02/07/14 20:06, Mathieu Poirier wrote: >>> +struct dentry *cs_debugfs_parent = NULL; >>> + >>> +static int curr_sink = NO_SINK; >>> +static LIST_HEAD(coresight_orph_conns); >>> +static LIST_HEAD(coresight_devs); >>> +static DEFINE_SEMAPHORE(coresight_mutex); >> >> Why is coresight_mutex a semaph

Re: [PATCH 1/9 v2] coresight: add CoreSight core layer framework

2014-07-02 Thread Mathieu Poirier
Thanks for the review - please see my comments inline. Mathieu On 2 July 2014 03:38, Daniel Thompson wrote: > On 27/06/14 19:04, mathieu.poir...@linaro.org wrote: >> diff --git a/drivers/coresight/Kconfig b/drivers/coresight/Kconfig >> new file mode 100644 >> index 000..fdd4d08 >> --- /dev/

Re: [PATCH 1/9 v2] coresight: add CoreSight core layer framework

2014-07-02 Thread Mathieu Poirier
On 30 June 2014 04:53, Dirk Behme wrote: > On 27.06.2014 20:04, mathieu.poir...@linaro.org wrote: >> >> From: Pratik Patel >> >> CoreSight components are compliant with the ARM CoreSight >> architecture specification and can be connected in various >> topologies to suite a particular SoCs tracing

Re: [PATCH 1/9 v2] coresight: add CoreSight core layer framework

2014-07-02 Thread Mathieu Poirier
On 27 June 2014 16:01, Rob Herring wrote: > On Fri, Jun 27, 2014 at 1:04 PM, wrote: >> From: Pratik Patel >> >> CoreSight components are compliant with the ARM CoreSight >> architecture specification and can be connected in various >> topologies to suite a particular SoCs tracing needs. These t

Re: [PATCH 1/9 v2] coresight: add CoreSight core layer framework

2014-07-02 Thread Daniel Thompson
On 27/06/14 19:04, mathieu.poir...@linaro.org wrote: > diff --git a/drivers/coresight/Kconfig b/drivers/coresight/Kconfig > new file mode 100644 > index 000..fdd4d08 > --- /dev/null > +++ b/drivers/coresight/Kconfig > @@ -0,0 +1,10 @@ > +menuconfig CORESIGHT > + bool "CoreSight Tracing Supp

Re: [PATCH 1/9 v2] coresight: add CoreSight core layer framework

2014-06-30 Thread Dirk Behme
On 27.06.2014 20:04, mathieu.poir...@linaro.org wrote: From: Pratik Patel CoreSight components are compliant with the ARM CoreSight architecture specification and can be connected in various topologies to suite a particular SoCs tracing needs. These trace components can generally be classified

Re: [PATCH 1/9 v2] coresight: add CoreSight core layer framework

2014-06-27 Thread Rob Herring
On Fri, Jun 27, 2014 at 1:04 PM, wrote: > From: Pratik Patel > > CoreSight components are compliant with the ARM CoreSight > architecture specification and can be connected in various > topologies to suite a particular SoCs tracing needs. These trace > components can generally be classified as s

[PATCH 1/9 v2] coresight: add CoreSight core layer framework

2014-06-27 Thread mathieu . poirier
From: Pratik Patel CoreSight components are compliant with the ARM CoreSight architecture specification and can be connected in various topologies to suite a particular SoCs tracing needs. These trace components can generally be classified as sources, links and sinks. Trace data produced by one o