Re: [PATCH 10/10] Replace tasklets with workqueues

2019-10-22 Thread Jason Gunthorpe
On Fri, Oct 11, 2019 at 12:41:50PM +0200, Maksym Planeta wrote: > Hi, > > this is a kind reminder regarding the patchset. I added description of races > in the original email. Your patch isn't on patchworks any more, you will need to send a v2 with the updated commit descriptions Jason

Re: [PATCH 10/10] Replace tasklets with workqueues

2019-10-11 Thread Maksym Planeta
Hi, this is a kind reminder regarding the patchset. I added description of races in the original email. On 30/07/2019 21:20, Maksym Planeta wrote: On 25/07/2019 20:50, Jason Gunthorpe wrote: On Thu, Jul 25, 2019 at 04:36:20PM +0200, Maksym Planeta wrote: Is this one better? Replace taskl

Re: [PATCH 10/10] Replace tasklets with workqueues

2019-07-30 Thread Maksym Planeta
On 25/07/2019 20:50, Jason Gunthorpe wrote: On Thu, Jul 25, 2019 at 04:36:20PM +0200, Maksym Planeta wrote: Is this one better? Replace tasklets with workqueues in rxe driver. The reason for this replacement is that tasklets are supposed to run atomically, although the actual code may block.

Re: [PATCH 10/10] Replace tasklets with workqueues

2019-07-25 Thread Jason Gunthorpe
On Thu, Jul 25, 2019 at 04:36:20PM +0200, Maksym Planeta wrote: > Is this one better? > > Replace tasklets with workqueues in rxe driver. The reason for this > replacement is that tasklets are supposed to run atomically, although the > actual code may block. > > Modify the SKB destructor for outg

Re: [PATCH 10/10] Replace tasklets with workqueues

2019-07-25 Thread Maksym Planeta
Is this one better? Replace tasklets with workqueues in rxe driver. The reason for this replacement is that tasklets are supposed to run atomically, although the actual code may block. Modify the SKB destructor for outgoing SKB's to schedule QP tasks only if the QP is not destroyed itself.

[PATCH 10/10] Replace tasklets with workqueues

2019-07-22 Thread Maksym Planeta
Replace tasklets with workqueues in rxe driver. Ensure that task is called only through a workqueue. This allows to simplify task logic. Add additional dependencies to make sure that cleanup tasks do not happen after object's memory is already reclaimed. Improve overal stability of the driver by

Re: [PATCH 10/10] Replace tasklets with workqueues

2019-07-22 Thread Jason Gunthorpe
On Mon, Jul 22, 2019 at 05:14:26PM +0200, Maksym Planeta wrote: > Replace tasklets with workqueues in rxe driver. > > Ensure that task is called only through a workqueue. This allows to > simplify task logic. > > Add additional dependencies to make sure that cleanup tasks do not > happen after ob