Re: [PATCH 10/10] media: uvcvideo: Populate only active control classes

2021-03-11 Thread Laurent Pinchart
Hi Ricardo, On Thu, Mar 11, 2021 at 04:21:38PM +0100, Ricardo Ribalda Delgado wrote: > On Thu, Mar 11, 2021 at 3:32 PM Hans Verkuil wrote: > > > > On 11/03/2021 13:20, Ricardo Ribalda wrote: > > > Do not create Control Classes for empty classes. > > > > Shouldn't this be squashed with patch 06/10

Re: [PATCH 10/10] media: uvcvideo: Populate only active control classes

2021-03-11 Thread Ricardo Ribalda Delgado
Hi Hans Thanks for your review! On Thu, Mar 11, 2021 at 3:32 PM Hans Verkuil wrote: > > On 11/03/2021 13:20, Ricardo Ribalda wrote: > > Do not create Control Classes for empty classes. > > Shouldn't this be squashed with patch 06/10? Most of the cameras I have used have the two classes, So I a

Re: [PATCH 10/10] media: uvcvideo: Populate only active control classes

2021-03-11 Thread Hans Verkuil
On 11/03/2021 13:20, Ricardo Ribalda wrote: > Do not create Control Classes for empty classes. Shouldn't this be squashed with patch 06/10? Regards, Hans > > Fixes v4l2-compliance: > > Control ioctls (Input 0): > fail: v4l2-test-controls.cpp(255): no controls in

[PATCH 10/10] media: uvcvideo: Populate only active control classes

2021-03-11 Thread Ricardo Ribalda
Do not create Control Classes for empty classes. Fixes v4l2-compliance: Control ioctls (Input 0): fail: v4l2-test-controls.cpp(255): no controls in class 009d test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: FAIL Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uv