Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-06-03 Thread Tomasz Figa
On Mon, Jun 3, 2019 at 4:26 PM Hans Verkuil wrote: > > On 5/31/19 10:01 AM, Stanimir Varbanov wrote: > > Hi, > > > > On 5/27/19 11:18 AM, Tomasz Figa wrote: > >> On Mon, May 27, 2019 at 4:39 PM Hans Verkuil wrote: > >>> > >>> On 5/27/19 5:51 AM, Tomasz Figa wrote: > On Tue, May 21, 2019 at 9

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-06-03 Thread Hans Verkuil
On 5/31/19 10:01 AM, Stanimir Varbanov wrote: > Hi, > > On 5/27/19 11:18 AM, Tomasz Figa wrote: >> On Mon, May 27, 2019 at 4:39 PM Hans Verkuil wrote: >>> >>> On 5/27/19 5:51 AM, Tomasz Figa wrote: On Tue, May 21, 2019 at 9:27 PM Hans Verkuil wrote: > > On 5/21/19 11:09 AM, Tomasz F

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-05-31 Thread Nicolas Dufresne
Le vendredi 31 mai 2019 à 11:01 +0300, Stanimir Varbanov a écrit : > Hi, > > On 5/27/19 11:18 AM, Tomasz Figa wrote: > > On Mon, May 27, 2019 at 4:39 PM Hans Verkuil wrote: > > > On 5/27/19 5:51 AM, Tomasz Figa wrote: > > > > On Tue, May 21, 2019 at 9:27 PM Hans Verkuil wrote: > > > > > On 5/21/

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-05-31 Thread Stanimir Varbanov
Hi, On 5/27/19 11:18 AM, Tomasz Figa wrote: > On Mon, May 27, 2019 at 4:39 PM Hans Verkuil wrote: >> >> On 5/27/19 5:51 AM, Tomasz Figa wrote: >>> On Tue, May 21, 2019 at 9:27 PM Hans Verkuil wrote: On 5/21/19 11:09 AM, Tomasz Figa wrote: > Hi Stan, > > On Mon, May 20, 2019

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-05-27 Thread Tomasz Figa
On Mon, May 27, 2019 at 4:39 PM Hans Verkuil wrote: > > On 5/27/19 5:51 AM, Tomasz Figa wrote: > > On Tue, May 21, 2019 at 9:27 PM Hans Verkuil wrote: > >> > >> On 5/21/19 11:09 AM, Tomasz Figa wrote: > >>> Hi Stan, > >>> > >>> On Mon, May 20, 2019 at 11:47 PM Stanimir Varbanov > >>> wrote: > >>

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-05-27 Thread Hans Verkuil
On 5/27/19 5:51 AM, Tomasz Figa wrote: > On Tue, May 21, 2019 at 9:27 PM Hans Verkuil wrote: >> >> On 5/21/19 11:09 AM, Tomasz Figa wrote: >>> Hi Stan, >>> >>> On Mon, May 20, 2019 at 11:47 PM Stanimir Varbanov >>> wrote: Hi Tomasz, On 4/24/19 3:39 PM, Tomasz Figa wrote: >

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-05-26 Thread Tomasz Figa
On Tue, May 21, 2019 at 9:27 PM Hans Verkuil wrote: > > On 5/21/19 11:09 AM, Tomasz Figa wrote: > > Hi Stan, > > > > On Mon, May 20, 2019 at 11:47 PM Stanimir Varbanov > > wrote: > >> > >> Hi Tomasz, > >> > >> On 4/24/19 3:39 PM, Tomasz Figa wrote: > >>> On Wed, Apr 24, 2019 at 9:15 PM Stanimir V

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-05-21 Thread Hans Verkuil
On 5/21/19 11:09 AM, Tomasz Figa wrote: > Hi Stan, > > On Mon, May 20, 2019 at 11:47 PM Stanimir Varbanov > wrote: >> >> Hi Tomasz, >> >> On 4/24/19 3:39 PM, Tomasz Figa wrote: >>> On Wed, Apr 24, 2019 at 9:15 PM Stanimir Varbanov >>> wrote: Hi Hans, On 2/15/19 3:44 PM, Hans

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-05-21 Thread Tomasz Figa
Hi Stan, On Mon, May 20, 2019 at 11:47 PM Stanimir Varbanov wrote: > > Hi Tomasz, > > On 4/24/19 3:39 PM, Tomasz Figa wrote: > > On Wed, Apr 24, 2019 at 9:15 PM Stanimir Varbanov > > wrote: > >> > >> Hi Hans, > >> > >> On 2/15/19 3:44 PM, Hans Verkuil wrote: > >>> Hi Stanimir, > >>> > >>> I neve

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-05-20 Thread Stanimir Varbanov
Hi Tomasz, On 4/24/19 3:39 PM, Tomasz Figa wrote: > On Wed, Apr 24, 2019 at 9:15 PM Stanimir Varbanov > wrote: >> >> Hi Hans, >> >> On 2/15/19 3:44 PM, Hans Verkuil wrote: >>> Hi Stanimir, >>> >>> I never paid much attention to this patch series since others were busy >>> discussing it and I had

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-04-09 Thread Tomasz Figa
On Wed, Apr 10, 2019 at 1:31 AM Nicolas Dufresne wrote: > > Le mardi 09 avril 2019 à 18:59 +0900, Tomasz Figa a écrit : > > On Thu, Feb 7, 2019 at 4:33 PM Tomasz Figa wrote: > > > On Tue, Feb 5, 2019 at 7:35 PM Hans Verkuil wrote: > > > > On 2/5/19 10:31 AM, Tomasz Figa wrote: > > > > > On Tue,

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Hans Verkuil
On 2/15/19 5:27 PM, Nicolas Dufresne wrote: > Le vendredi 15 février 2019 à 14:44 +0100, Hans Verkuil a écrit : >> Hi Stanimir, >> >> I never paid much attention to this patch series since others were busy >> discussing it and I had a lot of other things on my plate, but then I heard >> that this p

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Nicolas Dufresne
Le vendredi 15 février 2019 à 14:44 +0100, Hans Verkuil a écrit : > Hi Stanimir, > > I never paid much attention to this patch series since others were busy > discussing it and I had a lot of other things on my plate, but then I heard > that this patch made G_FMT blocking. > > That's a no-go. App

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-15 Thread Hans Verkuil
Hi Stanimir, I never paid much attention to this patch series since others were busy discussing it and I had a lot of other things on my plate, but then I heard that this patch made G_FMT blocking. That's a no-go. Apparently s5p-mfc does that as well, and that's against the V4L2 spec as well (cle

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-14 Thread Nicolas Dufresne
Le jeudi 14 février 2019 à 11:43 +0900, Tomasz Figa a écrit : > > > > No, I exactly meant the OUTPUT queue. The behavior of s5p-mfc in case > > > > of the format not being detected yet is to waits for any pending > > > > bitstream buffers to be processed by the decoder before returning an > > > > e

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-13 Thread Tomasz Figa
On Thu, Feb 7, 2019 at 4:33 PM Tomasz Figa wrote: > > On Tue, Feb 5, 2019 at 7:35 PM Hans Verkuil wrote: > > > > On 2/5/19 10:31 AM, Tomasz Figa wrote: > > > On Tue, Feb 5, 2019 at 6:00 PM Hans Verkuil wrote: > > >> > > >> On 2/5/19 7:26 AM, Tomasz Figa wrote: > > >>> On Fri, Feb 1, 2019 at 12:1

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-06 Thread Tomasz Figa
On Tue, Feb 5, 2019 at 7:35 PM Hans Verkuil wrote: > > On 2/5/19 10:31 AM, Tomasz Figa wrote: > > On Tue, Feb 5, 2019 at 6:00 PM Hans Verkuil wrote: > >> > >> On 2/5/19 7:26 AM, Tomasz Figa wrote: > >>> On Fri, Feb 1, 2019 at 12:18 AM Nicolas Dufresne > >>> wrote: > > Le jeudi 31 janv

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-05 Thread Hans Verkuil
On 2/5/19 10:31 AM, Tomasz Figa wrote: > On Tue, Feb 5, 2019 at 6:00 PM Hans Verkuil wrote: >> >> On 2/5/19 7:26 AM, Tomasz Figa wrote: >>> On Fri, Feb 1, 2019 at 12:18 AM Nicolas Dufresne >>> wrote: Le jeudi 31 janvier 2019 à 22:34 +0900, Tomasz Figa a écrit : > On Thu, Jan 31, 20

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-05 Thread Tomasz Figa
On Tue, Feb 5, 2019 at 6:00 PM Hans Verkuil wrote: > > On 2/5/19 7:26 AM, Tomasz Figa wrote: > > On Fri, Feb 1, 2019 at 12:18 AM Nicolas Dufresne > > wrote: > >> > >> Le jeudi 31 janvier 2019 à 22:34 +0900, Tomasz Figa a écrit : > >>> On Thu, Jan 31, 2019 at 9:42 PM Philipp Zabel > >>> wrote:

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-05 Thread Hans Verkuil
On 2/5/19 7:26 AM, Tomasz Figa wrote: > On Fri, Feb 1, 2019 at 12:18 AM Nicolas Dufresne wrote: >> >> Le jeudi 31 janvier 2019 à 22:34 +0900, Tomasz Figa a écrit : >>> On Thu, Jan 31, 2019 at 9:42 PM Philipp Zabel >>> wrote: Hi Nicolas, On Wed, 2019-01-30 at 10:32 -0500, Nicolas D

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-02-04 Thread Tomasz Figa
On Fri, Feb 1, 2019 at 12:18 AM Nicolas Dufresne wrote: > > Le jeudi 31 janvier 2019 à 22:34 +0900, Tomasz Figa a écrit : > > On Thu, Jan 31, 2019 at 9:42 PM Philipp Zabel > > wrote: > > > Hi Nicolas, > > > > > > On Wed, 2019-01-30 at 10:32 -0500, Nicolas Dufresne wrote: > > > > Le mercredi 30 j

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-31 Thread Nicolas Dufresne
Le jeudi 31 janvier 2019 à 22:34 +0900, Tomasz Figa a écrit : > On Thu, Jan 31, 2019 at 9:42 PM Philipp Zabel wrote: > > Hi Nicolas, > > > > On Wed, 2019-01-30 at 10:32 -0500, Nicolas Dufresne wrote: > > > Le mercredi 30 janvier 2019 à 15:17 +0900, Tomasz Figa a écrit : > > > > > I don't remember

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-31 Thread Tomasz Figa
On Thu, Jan 31, 2019 at 9:42 PM Philipp Zabel wrote: > > Hi Nicolas, > > On Wed, 2019-01-30 at 10:32 -0500, Nicolas Dufresne wrote: > > Le mercredi 30 janvier 2019 à 15:17 +0900, Tomasz Figa a écrit : > > > > I don't remember saying that, maybe I meant to say there might be a > > > > workaround ?

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-31 Thread Philipp Zabel
Hi Nicolas, On Wed, 2019-01-30 at 10:32 -0500, Nicolas Dufresne wrote: > Le mercredi 30 janvier 2019 à 15:17 +0900, Tomasz Figa a écrit : > > > I don't remember saying that, maybe I meant to say there might be a > > > workaround ? > > > > > > For the fact, here we queue the headers (or first fram

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-30 Thread Nicolas Dufresne
Le mercredi 30 janvier 2019 à 15:17 +0900, Tomasz Figa a écrit : > > I don't remember saying that, maybe I meant to say there might be a > > workaround ? > > > > For the fact, here we queue the headers (or first frame): > > > > https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/blob/master

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-29 Thread Tomasz Figa
On Wed, Jan 30, 2019 at 1:21 PM Nicolas Dufresne wrote: > > Le mercredi 30 janvier 2019 à 12:38 +0900, Tomasz Figa a écrit : > > > Yes, unfortunately, GStreamer still rely on G_FMT waiting a minimal > > > amount of time of the headers to be processed. This was how things was > > > created back in

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-29 Thread Nicolas Dufresne
Le mercredi 30 janvier 2019 à 12:38 +0900, Tomasz Figa a écrit : > > Yes, unfortunately, GStreamer still rely on G_FMT waiting a minimal > > amount of time of the headers to be processed. This was how things was > > created back in 2011, I could not program GStreamer for the future. If > > we stop

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-29 Thread Tomasz Figa
On Wed, Jan 30, 2019 at 12:18 PM Nicolas Dufresne wrote: > > Le lundi 28 janvier 2019 à 16:38 +0900, Tomasz Figa a écrit : > > > > Nope, that's not what is expected to happen here. Especially since > > > > you're potentially in non-blocking IO mode. Regardless of that, the > > > > > > OK, how to h

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-29 Thread Nicolas Dufresne
Le lundi 28 janvier 2019 à 16:38 +0900, Tomasz Figa a écrit : > > > Nope, that's not what is expected to happen here. Especially since > > > you're potentially in non-blocking IO mode. Regardless of that, the > > > > OK, how to handle that when userspace (for example gstreamer) hasn't > > support

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-29 Thread Tomasz Figa
On Tue, Jan 29, 2019 at 1:28 AM Stanimir Varbanov wrote: > > Hi Tomasz, > > On 1/28/19 9:38 AM, Tomasz Figa wrote: > > On Fri, Jan 25, 2019 at 7:25 PM Stanimir Varbanov > > wrote: > >> > >> Hi Tomasz, > >> > >> Thanks for the comments! > >> > >> On 1/25/19 9:59 AM, Tomasz Figa wrote: > >>> .Hi St

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-28 Thread Stanimir Varbanov
Hi Tomasz, On 1/28/19 9:38 AM, Tomasz Figa wrote: > On Fri, Jan 25, 2019 at 7:25 PM Stanimir Varbanov > wrote: >> >> Hi Tomasz, >> >> Thanks for the comments! >> >> On 1/25/19 9:59 AM, Tomasz Figa wrote: >>> .Hi Stan, >>> >>> On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov >>> wrote:

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-27 Thread Tomasz Figa
On Fri, Jan 25, 2019 at 7:25 PM Stanimir Varbanov wrote: > > Hi Tomasz, > > Thanks for the comments! > > On 1/25/19 9:59 AM, Tomasz Figa wrote: > > .Hi Stan, > > > > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov > > wrote: > >> > >> This refactored code for start/stop streaming vb2 operations

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-25 Thread Stanimir Varbanov
Hi Tomasz, Thanks for the comments! On 1/25/19 9:59 AM, Tomasz Figa wrote: > .Hi Stan, > > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov > wrote: >> >> This refactored code for start/stop streaming vb2 operations and >> adds a state machine handling similar to the one in stateful codec >> A

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-25 Thread Tomasz Figa
.Hi Stan, On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov wrote: > > This refactored code for start/stop streaming vb2 operations and > adds a state machine handling similar to the one in stateful codec > API documentation. One major change is that now the HFI session is > started on STREAMON(O

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-24 Thread Alexandre Courbot
On Thu, Jan 24, 2019 at 9:34 PM Stanimir Varbanov wrote: > > Hi Alex, > > Thanks for the comments! > > On 1/24/19 10:44 AM, Alexandre Courbot wrote: > > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov > > wrote: > >> > >> This refactored code for start/stop streaming vb2 operations and > > > >

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-24 Thread Stanimir Varbanov
Hi Alex, Thanks for the comments! On 1/24/19 10:44 AM, Alexandre Courbot wrote: > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov > wrote: >> >> This refactored code for start/stop streaming vb2 operations and > > s/refactored/refactors? Ack. > >> adds a state machine handling similar to t

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-24 Thread Stanimir Varbanov
Hi Malathi, On 1/21/19 1:20 PM, mgot...@codeaurora.org wrote: > On 2019-01-17 21:50, Stanimir Varbanov wrote: >> This refactored code for start/stop streaming vb2 operations and >> adds a state machine handling similar to the one in stateful codec >> API documentation. One major change is that now

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-24 Thread Alexandre Courbot
On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov wrote: > > This refactored code for start/stop streaming vb2 operations and s/refactored/refactors? > adds a state machine handling similar to the one in stateful codec > API documentation. One major change is that now the HFI session is > starte

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-21 Thread mgottam
On 2019-01-21 16:50, mgot...@codeaurora.org wrote: On 2019-01-17 21:50, Stanimir Varbanov wrote: This refactored code for start/stop streaming vb2 operations and adds a state machine handling similar to the one in stateful codec API documentation. One major change is that now the HFI session is

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-21 Thread mgottam
On 2019-01-17 21:50, Stanimir Varbanov wrote: This refactored code for start/stop streaming vb2 operations and adds a state machine handling similar to the one in stateful codec API documentation. One major change is that now the HFI session is started on STREAMON(OUTPUT) and stopped on REQBUF(OU

[PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-17 Thread Stanimir Varbanov
This refactored code for start/stop streaming vb2 operations and adds a state machine handling similar to the one in stateful codec API documentation. One major change is that now the HFI session is started on STREAMON(OUTPUT) and stopped on REQBUF(OUTPUT,count=0), during that time streamoff(cap,ou