Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Peter Zijlstra
On Mon, Jun 01, 2015 at 11:35:18AM -0400, Paul Gortmaker wrote: > OK, so how about I update both logs with something like this, to > clarify I meant "no way this code can be modular currently, given > the existing Kconfig situation": That looks good to me; thanks! -- To unsubscribe from this

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Paul Gortmaker
On 15-06-01 10:14 AM, Peter Zijlstra wrote: > On Mon, 2015-06-01 at 10:11 -0400, Paul Gortmaker wrote: >> On 15-06-01 03:04 AM, Peter Zijlstra wrote: >>> On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: This was using module_init, but there is no way this code can be

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Peter Zijlstra
On Mon, 2015-06-01 at 10:11 -0400, Paul Gortmaker wrote: > On 15-06-01 03:04 AM, Peter Zijlstra wrote: > > On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: > >> This was using module_init, but there is no way this code can > >> be modular. > > > > No, I think you could actually

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Paul Gortmaker
On 15-06-01 03:04 AM, Peter Zijlstra wrote: > On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: >> This was using module_init, but there is no way this code can >> be modular. > > No, I think you could actually make it modular if you really wanted to. By "really wanted to" -- do

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Peter Zijlstra
On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: > This was using module_init, but there is no way this code can > be modular. No, I think you could actually make it modular if you really wanted to. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Peter Zijlstra
On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: This was using module_init, but there is no way this code can be modular. No, I think you could actually make it modular if you really wanted to. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Paul Gortmaker
On 15-06-01 10:14 AM, Peter Zijlstra wrote: On Mon, 2015-06-01 at 10:11 -0400, Paul Gortmaker wrote: On 15-06-01 03:04 AM, Peter Zijlstra wrote: On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: This was using module_init, but there is no way this code can be modular. No, I

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Peter Zijlstra
On Mon, Jun 01, 2015 at 11:35:18AM -0400, Paul Gortmaker wrote: OK, so how about I update both logs with something like this, to clarify I meant no way this code can be modular currently, given the existing Kconfig situation: That looks good to me; thanks! -- To unsubscribe from this list:

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Peter Zijlstra
On Mon, 2015-06-01 at 10:11 -0400, Paul Gortmaker wrote: On 15-06-01 03:04 AM, Peter Zijlstra wrote: On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: This was using module_init, but there is no way this code can be modular. No, I think you could actually make it

Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-06-01 Thread Paul Gortmaker
On 15-06-01 03:04 AM, Peter Zijlstra wrote: On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: This was using module_init, but there is no way this code can be modular. No, I think you could actually make it modular if you really wanted to. By really wanted to -- do you mean

[PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-05-31 Thread Paul Gortmaker
This was using module_init, but there is no way this code can be modular. In the non-modular case, a module_init becomes a device_initcall, but this really isn't a device. So we should choose a more appropriate initcall bucket to put it in. The obvious choice here seems to be arch_initcall,

[PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling

2015-05-31 Thread Paul Gortmaker
This was using module_init, but there is no way this code can be modular. In the non-modular case, a module_init becomes a device_initcall, but this really isn't a device. So we should choose a more appropriate initcall bucket to put it in. The obvious choice here seems to be arch_initcall,