Re: [PATCH 10/12] drm: bridge/dw_hdmi: fix phy enable/disable handling

2015-10-08 Thread Yakir Yang
Oh, I haven't noticed that those patches already have been merged into linux-next :-) On 10/08/2015 03:17 AM, Russell King - ARM Linux wrote: On Wed, Oct 07, 2015 at 06:40:11PM +0800, Yakir Yang wrote: On 10/07/2015 05:48 PM, Russell King - ARM Linux wrote: On Wed, Oct 07, 2015 at

Re: [PATCH 10/12] drm: bridge/dw_hdmi: fix phy enable/disable handling

2015-10-08 Thread Yakir Yang
Oh, I haven't noticed that those patches already have been merged into linux-next :-) On 10/08/2015 03:17 AM, Russell King - ARM Linux wrote: On Wed, Oct 07, 2015 at 06:40:11PM +0800, Yakir Yang wrote: On 10/07/2015 05:48 PM, Russell King - ARM Linux wrote: On Wed, Oct 07, 2015 at

Re: [PATCH 10/12] drm: bridge/dw_hdmi: fix phy enable/disable handling

2015-10-07 Thread Russell King - ARM Linux
On Wed, Oct 07, 2015 at 06:40:11PM +0800, Yakir Yang wrote: > > > On 10/07/2015 05:48 PM, Russell King - ARM Linux wrote: > >On Wed, Oct 07, 2015 at 12:05:37PM +0800, Yakir Yang wrote: > >> > >>On 08/09/2015 12:04 AM, Russell King wrote: > >>>The dw_hdmi enable/disable handling is particularly

Re: [PATCH 10/12] drm: bridge/dw_hdmi: fix phy enable/disable handling

2015-10-07 Thread Russell King - ARM Linux
On Wed, Oct 07, 2015 at 12:05:37PM +0800, Yakir Yang wrote: > > > On 08/09/2015 12:04 AM, Russell King wrote: > >The dw_hdmi enable/disable handling is particularly weak in several > >regards: > >* The hotplug interrupt could call hdmi_poweron() or hdmi_poweroff() > > while DRM is setting a

Re: [PATCH 10/12] drm: bridge/dw_hdmi: fix phy enable/disable handling

2015-10-07 Thread Russell King - ARM Linux
On Wed, Oct 07, 2015 at 06:40:11PM +0800, Yakir Yang wrote: > > > On 10/07/2015 05:48 PM, Russell King - ARM Linux wrote: > >On Wed, Oct 07, 2015 at 12:05:37PM +0800, Yakir Yang wrote: > >> > >>On 08/09/2015 12:04 AM, Russell King wrote: > >>>The dw_hdmi enable/disable handling is particularly

Re: [PATCH 10/12] drm: bridge/dw_hdmi: fix phy enable/disable handling

2015-10-07 Thread Russell King - ARM Linux
On Wed, Oct 07, 2015 at 12:05:37PM +0800, Yakir Yang wrote: > > > On 08/09/2015 12:04 AM, Russell King wrote: > >The dw_hdmi enable/disable handling is particularly weak in several > >regards: > >* The hotplug interrupt could call hdmi_poweron() or hdmi_poweroff() > > while DRM is setting a

[PATCH 10/12] drm: bridge/dw_hdmi: fix phy enable/disable handling

2015-08-08 Thread Russell King
The dw_hdmi enable/disable handling is particularly weak in several regards: * The hotplug interrupt could call hdmi_poweron() or hdmi_poweroff() while DRM is setting a mode, which could race with a mode being set. * Hotplug will always re-enable the phy whenever it detects an active hotplug

[PATCH 10/12] drm: bridge/dw_hdmi: fix phy enable/disable handling

2015-08-08 Thread Russell King
The dw_hdmi enable/disable handling is particularly weak in several regards: * The hotplug interrupt could call hdmi_poweron() or hdmi_poweroff() while DRM is setting a mode, which could race with a mode being set. * Hotplug will always re-enable the phy whenever it detects an active hotplug