Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-17 Thread Darren Hart
On Wed, Sep 17, 2014 at 01:57:33PM +0200, Frans Klaver wrote: > On Wed, Sep 17, 2014 at 12:34 PM, Henrique de Moraes Holschuh > wrote: > > On Tue, 16 Sep 2014, Darren Hart wrote: > >> - When reading and writing sysfs device attribute files, avoid dependency > >> on specific error codes wherever

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-17 Thread Frans Klaver
On Wed, Sep 17, 2014 at 12:34 PM, Henrique de Moraes Holschuh wrote: > On Tue, 16 Sep 2014, Darren Hart wrote: >> - When reading and writing sysfs device attribute files, avoid dependency >> on specific error codes wherever possible. This minimizes coupling to >> the error handling

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-17 Thread Henrique de Moraes Holschuh
On Tue, 16 Sep 2014, Darren Hart wrote: > - When reading and writing sysfs device attribute files, avoid dependency > on specific error codes wherever possible. This minimizes coupling to > the error handling implemementation within the kernel. > > In general, failures to read or write

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-17 Thread Henrique de Moraes Holschuh
On Tue, 16 Sep 2014, Darren Hart wrote: - When reading and writing sysfs device attribute files, avoid dependency on specific error codes wherever possible. This minimizes coupling to the error handling implemementation within the kernel. In general, failures to read or write sysfs

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-17 Thread Frans Klaver
On Wed, Sep 17, 2014 at 12:34 PM, Henrique de Moraes Holschuh h...@hmh.eng.br wrote: On Tue, 16 Sep 2014, Darren Hart wrote: - When reading and writing sysfs device attribute files, avoid dependency on specific error codes wherever possible. This minimizes coupling to the error handling

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-17 Thread Darren Hart
On Wed, Sep 17, 2014 at 01:57:33PM +0200, Frans Klaver wrote: On Wed, Sep 17, 2014 at 12:34 PM, Henrique de Moraes Holschuh h...@hmh.eng.br wrote: On Tue, 16 Sep 2014, Darren Hart wrote: - When reading and writing sysfs device attribute files, avoid dependency on specific error codes

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Darren Hart
On Tue, Sep 16, 2014 at 11:10:01PM +0200, Frans Klaver wrote: > On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote: > > On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: > > > On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver > > > wrote: > > > > On Mon, Sep 15, 2014 at

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Darren Hart
On Tue, Sep 16, 2014 at 11:40:37PM +0200, Frans Klaver wrote: > On Tue, Sep 16, 2014 at 02:27:15PM -0700, Darren Hart wrote: > > > > - When reading and writing sysfs device attribute files, avoid dependency > > on specific error codes wherever possible. This minimizes coupling to > > the

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Frans Klaver
On Tue, Sep 16, 2014 at 02:27:15PM -0700, Darren Hart wrote: > > - When reading and writing sysfs device attribute files, avoid dependency > on specific error codes wherever possible. This minimizes coupling to > the error handling implemementation within the kernel. > > In general,

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Greg Kroah-Hartman
On Tue, Sep 16, 2014 at 02:27:15PM -0700, Darren Hart wrote: > On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote: > > On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: > > > On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver > > > wrote: > > > > On Mon, Sep 15, 2014 at

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Darren Hart
On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote: > On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: > > On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver > > wrote: > > > On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: > > >> On Mon, Sep 15, 2014 at

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Frans Klaver
On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote: > On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: > > On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver > > wrote: > > > On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: > > >> On Mon, Sep 15, 2014 at

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Darren Hart
On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: > On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver wrote: > > On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: > >> On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote: > >> > > >> > This patch is fine as is.

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Frans Klaver
On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver wrote: > On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: >> On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote: >> > >> > This patch is fine as is. However, Greg has supported propogating the >> > error code >> > through

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Frans Klaver
On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver franskla...@gmail.com wrote: On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote: This patch is fine as is. However, Greg has supported propogating the error code

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Darren Hart
On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver franskla...@gmail.com wrote: On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote: This patch is fine

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Frans Klaver
On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote: On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver franskla...@gmail.com wrote: On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: On Mon, Sep 15,

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Darren Hart
On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote: On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver franskla...@gmail.com wrote: On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: On Mon, Sep 15,

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Greg Kroah-Hartman
On Tue, Sep 16, 2014 at 02:27:15PM -0700, Darren Hart wrote: On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote: On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver franskla...@gmail.com wrote: On Mon, Sep 15, 2014 at

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Frans Klaver
On Tue, Sep 16, 2014 at 02:27:15PM -0700, Darren Hart wrote: - When reading and writing sysfs device attribute files, avoid dependency on specific error codes wherever possible. This minimizes coupling to the error handling implemementation within the kernel. In general, failures to

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Darren Hart
On Tue, Sep 16, 2014 at 11:40:37PM +0200, Frans Klaver wrote: On Tue, Sep 16, 2014 at 02:27:15PM -0700, Darren Hart wrote: - When reading and writing sysfs device attribute files, avoid dependency on specific error codes wherever possible. This minimizes coupling to the error

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-16 Thread Darren Hart
On Tue, Sep 16, 2014 at 11:10:01PM +0200, Frans Klaver wrote: On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote: On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote: On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver franskla...@gmail.com wrote: On Mon, Sep 15, 2014 at

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-15 Thread Frans Klaver
On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: > On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote: > > On Sat, Sep 13, 2014 at 01:06:49AM +0200, Frans Klaver wrote: > > > In get_cpufv the return value of get_acpi is stored in the cpufv struct. > > > Right before

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-15 Thread Greg Kroah-Hartman
On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote: > On Sat, Sep 13, 2014 at 01:06:49AM +0200, Frans Klaver wrote: > > In get_cpufv the return value of get_acpi is stored in the cpufv struct. > > Right before this value is checked for errors, it is and'ed with 0xff. > > This means c->cur

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-15 Thread Darren Hart
On Sat, Sep 13, 2014 at 01:06:49AM +0200, Frans Klaver wrote: > In get_cpufv the return value of get_acpi is stored in the cpufv struct. > Right before this value is checked for errors, it is and'ed with 0xff. > This means c->cur can never be less than zero. Besides that, the actual > error value

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-15 Thread Darren Hart
On Sat, Sep 13, 2014 at 01:06:49AM +0200, Frans Klaver wrote: In get_cpufv the return value of get_acpi is stored in the cpufv struct. Right before this value is checked for errors, it is and'ed with 0xff. This means c-cur can never be less than zero. Besides that, the actual error value is

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-15 Thread Greg Kroah-Hartman
On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote: On Sat, Sep 13, 2014 at 01:06:49AM +0200, Frans Klaver wrote: In get_cpufv the return value of get_acpi is stored in the cpufv struct. Right before this value is checked for errors, it is and'ed with 0xff. This means c-cur can

Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-15 Thread Frans Klaver
On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote: On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote: On Sat, Sep 13, 2014 at 01:06:49AM +0200, Frans Klaver wrote: In get_cpufv the return value of get_acpi is stored in the cpufv struct. Right before this value

[PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-12 Thread Frans Klaver
In get_cpufv the return value of get_acpi is stored in the cpufv struct. Right before this value is checked for errors, it is and'ed with 0xff. This means c->cur can never be less than zero. Besides that, the actual error value is ignored. c->num is also and'ed with 0xff, which means we can

[PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv

2014-09-12 Thread Frans Klaver
In get_cpufv the return value of get_acpi is stored in the cpufv struct. Right before this value is checked for errors, it is and'ed with 0xff. This means c-cur can never be less than zero. Besides that, the actual error value is ignored. c-num is also and'ed with 0xff, which means we can ignore